You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2021/09/16 11:15:37 UTC

[GitHub] [servicecomb-java-chassis] david6969xin opened a new pull request #2583: [#2551] simplified profile path in cse_run.log

david6969xin opened a new pull request #2583:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2583


   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[SCB-XXX] Fixes bug in ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean install -Pit` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2583: [#2551] simplified profile path in cse_run.log

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2583:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2583#discussion_r711518632



##########
File path: foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/IOUtils.java
##########
@@ -18,9 +18,37 @@
 
 import java.io.Closeable;
 
+import org.apache.commons.lang3.StringUtils;
+
 public class IOUtils {
   @SuppressWarnings("deprecation")
   public static void closeQuietly(final Closeable closeable) {
     org.apache.commons.io.IOUtils.closeQuietly(closeable);
   }
+
+  public static String convertString(String origin) {
+    return convertString(origin,System.getProperty("file.separator").charAt(0));

Review comment:
       extract a constant for this




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter edited a comment on pull request #2583: [#2551] simplified profile path in cse_run.log

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2583:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2583#issuecomment-921459686


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2583](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (56d7456) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/fff8c3e97fcbcf1572f27ae1cd8443a7cebeb19c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fff8c3e) will **increase** coverage by `0.01%`.
   > The diff coverage is `100.00%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2583      +/-   ##
   ============================================
   + Coverage     77.67%   77.69%   +0.01%     
     Complexity     1427     1427              
   ============================================
     Files          1598     1598              
     Lines         42574    42586      +12     
     Branches       3588     3588              
   ============================================
   + Hits          33071    33088      +17     
   + Misses         8003     7999       -4     
   + Partials       1500     1499       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...e/servicecomb/foundation/common/utils/IOUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL3V0aWxzL0lPVXRpbHMuamF2YQ==) | `92.30% <100.00%> (+25.64%)` | :arrow_up: |
   | [...ervicecomb/foundation/common/utils/Log4jUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL3V0aWxzL0xvZzRqVXRpbHMuamF2YQ==) | `79.59% <100.00%> (ø)` | |
   | [...rvicecomb/config/archaius/sources/ConfigModel.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9hcmNoYWl1cy9zb3VyY2VzL0NvbmZpZ01vZGVsLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...ervicecomb/foundation/vertx/stream/PumpCommon.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZm91bmRhdGlvbi92ZXJ0eC9zdHJlYW0vUHVtcENvbW1vbi5qYXZh) | `70.37% <0.00%> (-7.41%)` | :arrow_down: |
   | [.../servicecomb/registry/discovery/DiscoveryTree.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvZGlzY292ZXJ5L0Rpc2NvdmVyeVRyZWUuamF2YQ==) | `96.49% <0.00%> (-3.51%)` | :arrow_down: |
   | [...cecomb/registry/consumer/MicroserviceVersions.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1yZWdpc3RyeS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvcmVnaXN0cnkvY29uc3VtZXIvTWljcm9zZXJ2aWNlVmVyc2lvbnMuamF2YQ==) | `87.39% <0.00%> (-1.69%)` | :arrow_down: |
   | [...pache/servicecomb/demo/pojo/client/PojoClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLXBvam8vcG9qby1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vcG9qby9jbGllbnQvUG9qb0NsaWVudC5qYXZh) | `82.60% <0.00%> (-0.28%)` | :arrow_down: |
   | [...vicecomb/demo/pojo/client/CodeFirstPojoClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLXBvam8vcG9qby1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vcG9qby9jbGllbnQvQ29kZUZpcnN0UG9qb0NsaWVudC5qYXZh) | `97.77% <0.00%> (+0.34%)` | :arrow_up: |
   | [...dation/protobuf/internal/schema/map/MapSchema.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1wcm90b2J1Zi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZm91bmRhdGlvbi9wcm90b2J1Zi9pbnRlcm5hbC9zY2hlbWEvbWFwL01hcFNjaGVtYS5qYXZh) | `93.33% <0.00%> (+3.33%)` | :arrow_up: |
   | [...ache/servicecomb/foundation/common/net/IpPort.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL25ldC9JcFBvcnQuamF2YQ==) | `86.66% <0.00%> (+3.33%)` | :arrow_up: |
   | ... and [3 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fff8c3e...56d7456](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2583: [#2551] simplified profile path in cse_run.log

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2583:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2583#discussion_r711518699



##########
File path: foundations/foundation-common/src/main/java/org/apache/servicecomb/foundation/common/utils/IOUtils.java
##########
@@ -18,9 +18,37 @@
 
 import java.io.Closeable;
 
+import org.apache.commons.lang3.StringUtils;
+
 public class IOUtils {
   @SuppressWarnings("deprecation")
   public static void closeQuietly(final Closeable closeable) {
     org.apache.commons.io.IOUtils.closeQuietly(closeable);
   }
+
+  public static String convertString(String origin) {
+    return convertString(origin,System.getProperty("file.separator").charAt(0));
+  }
+
+  public static String convertString(String origin, char separator) {
+    if (StringUtils.isEmpty(origin)) {
+      return "";

Review comment:
       return origin




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] david6969xin commented on a change in pull request #2583: [#2551] simplified profile path in cse_run.log

Posted by GitBox <gi...@apache.org>.
david6969xin commented on a change in pull request #2583:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2583#discussion_r710045913



##########
File path: foundations/foundation-config/src/main/java/org/apache/servicecomb/config/archaius/sources/ConfigModel.java
##########
@@ -54,6 +56,30 @@ public void setConfig(Map<String, Object> config) {
 
   @Override
   public String toString() {
-    return url == null ? "" : url.toString();
+    return url == null ? "" : convertUrl(url.toString());
+  }
+
+  public static String convertUrl(String urlString) {
+    String allUrl = urlString.substring(urlString.indexOf("file") + 8);
+    return (InitialsInfo(StringUtils.remove(allUrl, fileDetailInfo(allUrl))) + fileDetailInfo(allUrl)).substring(1);
+  }
+
+  private static String fileDetailInfo(String target) {
+    StringBuilder fileDetailString = new StringBuilder();
+    while (fileDetailString.toString().length() <= 20) {
+      fileDetailString.insert(0, target.substring(target.lastIndexOf("/")));
+      target = StringUtils.remove(target, target.substring(target.lastIndexOf("/")));
+    }
+    return fileDetailString.toString();
+  }
+
+  private static String InitialsInfo(String target) {
+    StringBuilder fileDetailString = new StringBuilder();
+    while (target.contains("/")) {
+      String temp = target.substring(target.indexOf("/"), target.indexOf("/") + 2);
+      fileDetailString.append(temp);
+      target = StringUtils.remove(target, temp);
+    }
+    return fileDetailString.toString();
   }

Review comment:
       ok




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2583: [#2551] simplified profile path in cse_run.log

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2583:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2583#discussion_r710047776



##########
File path: foundations/foundation-config/src/main/java/org/apache/servicecomb/config/archaius/sources/ConfigModel.java
##########
@@ -54,6 +56,30 @@ public void setConfig(Map<String, Object> config) {
 
   @Override
   public String toString() {
-    return url == null ? "" : url.toString();
+    return url == null ? "" : convertUrl(url.toString());
+  }
+
+  public static String convertUrl(String urlString) {
+    String allUrl = urlString.substring(urlString.indexOf("file") + 8);
+    return (InitialsInfo(StringUtils.remove(allUrl, fileDetailInfo(allUrl))) + fileDetailInfo(allUrl)).substring(1);
+  }
+
+  private static String fileDetailInfo(String target) {
+    StringBuilder fileDetailString = new StringBuilder();
+    while (fileDetailString.toString().length() <= 20) {
+      fileDetailString.insert(0, target.substring(target.lastIndexOf("/")));
+      target = StringUtils.remove(target, target.substring(target.lastIndexOf("/")));
+    }
+    return fileDetailString.toString();
+  }
+
+  private static String InitialsInfo(String target) {
+    StringBuilder fileDetailString = new StringBuilder();
+    while (target.contains("/")) {
+      String temp = target.substring(target.indexOf("/"), target.indexOf("/") + 2);
+      fileDetailString.append(temp);
+      target = StringUtils.remove(target, temp);
+    }
+    return fileDetailString.toString();
   }

Review comment:
       This algorithm is a bit complicated. e.gs
   
   String convertString(String orgin) {
       char[] seq = origin.length() > 60 ? origin.subString(0, 60) : origin.toChars();
       if(seq.lenght < 20) return ...
   
       StringBuilder sb = new StringBuilder();
       boolean m = false;
       for(int i = 0; i<seq.length - 20; i++) {
          if(c == '/' || c=='\\') {
   ...
          }
       }
   }




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 merged pull request #2583: [#2551] simplified profile path in cse_run.log

Posted by GitBox <gi...@apache.org>.
liubao68 merged pull request #2583:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2583


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2583: [#2551] simplified profile path in cse_run.log

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2583:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2583#discussion_r710042301



##########
File path: foundations/foundation-config/src/main/java/org/apache/servicecomb/config/archaius/sources/ConfigModel.java
##########
@@ -54,6 +56,30 @@ public void setConfig(Map<String, Object> config) {
 
   @Override
   public String toString() {
-    return url == null ? "" : url.toString();
+    return url == null ? "" : convertUrl(url.toString());
+  }
+
+  public static String convertUrl(String urlString) {
+    String allUrl = urlString.substring(urlString.indexOf("file") + 8);
+    return (InitialsInfo(StringUtils.remove(allUrl, fileDetailInfo(allUrl))) + fileDetailInfo(allUrl)).substring(1);
+  }
+
+  private static String fileDetailInfo(String target) {
+    StringBuilder fileDetailString = new StringBuilder();
+    while (fileDetailString.toString().length() <= 20) {
+      fileDetailString.insert(0, target.substring(target.lastIndexOf("/")));
+      target = StringUtils.remove(target, target.substring(target.lastIndexOf("/")));
+    }
+    return fileDetailString.toString();
+  }
+
+  private static String InitialsInfo(String target) {
+    StringBuilder fileDetailString = new StringBuilder();
+    while (target.contains("/")) {
+      String temp = target.substring(target.indexOf("/"), target.indexOf("/") + 2);
+      fileDetailString.append(temp);
+      target = StringUtils.remove(target, temp);
+    }
+    return fileDetailString.toString();
   }

Review comment:
       add a util method to org.apache.servicecomb.foundation.common.utils.IOUtils




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] codecov-commenter commented on pull request #2583: [#2551] simplified profile path in cse_run.log

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2583:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2583#issuecomment-921459686


   # [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#2583](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68868e8) into [master](https://codecov.io/gh/apache/servicecomb-java-chassis/commit/fff8c3e97fcbcf1572f27ae1cd8443a7cebeb19c?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fff8c3e) will **increase** coverage by `0.01%`.
   > The diff coverage is `97.87%`.
   
   > :exclamation: Current head 68868e8 differs from pull request most recent head c816cca. Consider uploading reports for the commit c816cca to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/graphs/tree.svg?width=650&height=150&src=pr&token=KXfDcr9rX2&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #2583      +/-   ##
   ============================================
   + Coverage     77.67%   77.69%   +0.01%     
     Complexity     1427     1427              
   ============================================
     Files          1598     1598              
     Lines         42574    42587      +13     
     Branches       3588     3589       +1     
   ============================================
   + Hits          33071    33088      +17     
   + Misses         8003     7998       -5     
   - Partials       1500     1501       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...pache/servicecomb/demo/pojo/client/PojoClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLXBvam8vcG9qby1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vcG9qby9jbGllbnQvUG9qb0NsaWVudC5qYXZh) | `82.60% <ø> (-0.28%)` | :arrow_down: |
   | [...e/servicecomb/foundation/common/utils/IOUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL3V0aWxzL0lPVXRpbHMuamF2YQ==) | `85.71% <90.90%> (+19.04%)` | :arrow_up: |
   | [...vicecomb/demo/pojo/client/CodeFirstPojoClient.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZGVtby9kZW1vLXBvam8vcG9qby1jbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2RlbW8vcG9qby9jbGllbnQvQ29kZUZpcnN0UG9qb0NsaWVudC5qYXZh) | `97.77% <100.00%> (+0.34%)` | :arrow_up: |
   | [...ervicecomb/foundation/common/utils/Log4jUtils.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2ZvdW5kYXRpb24vY29tbW9uL3V0aWxzL0xvZzRqVXRpbHMuamF2YQ==) | `79.59% <100.00%> (ø)` | |
   | [...rvicecomb/config/archaius/sources/ConfigModel.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi1jb25maWcvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NlcnZpY2Vjb21iL2NvbmZpZy9hcmNoYWl1cy9zb3VyY2VzL0NvbmZpZ01vZGVsLmphdmE=) | `100.00% <100.00%> (ø)` | |
   | [...n/java/org/apache/servicecomb/AuthHandlerBoot.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvQXV0aEhhbmRsZXJCb290LmphdmE=) | `100.00% <100.00%> (+20.00%)` | :arrow_up: |
   | [...icecomb/authentication/RSAAuthenticationToken.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vUlNBQXV0aGVudGljYXRpb25Ub2tlbi5qYXZh) | `100.00% <100.00%> (+6.45%)` | :arrow_up: |
   | [...thentication/provider/RSAProviderTokenManager.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-aGFuZGxlcnMvaGFuZGxlci1wdWJsaWNrZXktYXV0aC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvYXV0aGVudGljYXRpb24vcHJvdmlkZXIvUlNBUHJvdmlkZXJUb2tlbk1hbmFnZXIuamF2YQ==) | `78.37% <100.00%> (+5.65%)` | :arrow_up: |
   | [...ervicecomb/foundation/vertx/stream/PumpCommon.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Zm91bmRhdGlvbnMvZm91bmRhdGlvbi12ZXJ0eC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvZm91bmRhdGlvbi92ZXJ0eC9zdHJlYW0vUHVtcENvbW1vbi5qYXZh) | `70.37% <0.00%> (-7.41%)` | :arrow_down: |
   | [...comb/core/definition/MicroserviceVersionsMeta.java](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2VydmljZWNvbWIvY29yZS9kZWZpbml0aW9uL01pY3Jvc2VydmljZVZlcnNpb25zTWV0YS5qYXZh) | `94.73% <0.00%> (-5.27%)` | :arrow_down: |
   | ... and [2 more](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fff8c3e...c816cca](https://codecov.io/gh/apache/servicecomb-java-chassis/pull/2583?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2583: [#2551] simplified profile path in cse_run.log

Posted by GitBox <gi...@apache.org>.
liubao68 commented on a change in pull request #2583:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2583#discussion_r710041380



##########
File path: foundations/foundation-config/src/test/java/org/apache/servicecomb/config/archaius/sources/TestMicroserviceConfigLoader.java
##########
@@ -102,4 +102,15 @@ public void testLoadNotExistYaml() throws IOException {
       Assert.assertTrue(true);
     }
   }
+
+  @Test
+  public void testConvertUrl() {
+    String fileUrlOne = "file:/C:/gitSpace/servicecomb-java-chassis/transports"
+        + "/transport-highway/target/classes/microservice.yaml";
+    assertEquals("g/s/t/classes/microservice.yaml", ConfigModel.convertUrl(fileUrlOne));

Review comment:
       consider windows `D:\a.txt` 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org