You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by vrozov <gi...@git.apache.org> on 2018/04/18 22:44:10 UTC

[GitHub] drill pull request #1213: DRILL-6334: Minor code cleanup

Github user vrozov commented on a diff in the pull request:

    https://github.com/apache/drill/pull/1213#discussion_r182590683
  
    --- Diff: exec/vector/src/test/java/org/apache/drill/exec/vector/VariableLengthVectorTest.java ---
    @@ -37,6 +37,7 @@ public void testSettingSameValueCount()
       {
         try (RootAllocator allocator = new RootAllocator(10_000_000)) {
           final MaterializedField field = MaterializedField.create("stringCol", Types.required(TypeProtos.MinorType.VARCHAR));
    +      @SuppressWarnings("resource")
    --- End diff --
    
    @paul-rogers Thank you for making the changes. Can you please double check whether it is necessary to suppress the warning here. It is confusing why the same warning suppression is removed in some places and added in others.


---