You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/07/21 08:03:12 UTC
[GitHub] [flink] zentol commented on a change in pull request #16546: [FLINK-23438] Bump httpclient from 4.5.3 and 4.5.9 to 4.5.13
zentol commented on a change in pull request #16546:
URL: https://github.com/apache/flink/pull/16546#discussion_r673748129
##########
File path: flink-filesystems/flink-s3-fs-presto/pom.xml
##########
@@ -219,7 +219,7 @@ under the License.
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.9</version>
Review comment:
this entry could not be removed since it is subsumed by the root pom entry
##########
File path: flink-end-to-end-tests/flink-glue-schema-registry-test/pom.xml
##########
@@ -33,7 +33,7 @@ under the License.
<packaging>jar</packaging>
<properties>
- <httpclient.version>4.5.9</httpclient.version>
+ <httpclient.version>4.5.13</httpclient.version>
Review comment:
Are we not able to remove this property and the usages in this file?
##########
File path: flink-connectors/flink-connector-kinesis/pom.xml
##########
@@ -258,7 +258,7 @@ under the License.
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.9</version>
+ <version>4.5.13</version>
Review comment:
same comment as for the filesystems
##########
File path: flink-filesystems/flink-s3-fs-hadoop/pom.xml
##########
@@ -46,7 +46,7 @@ under the License.
<dependency>
<groupId>org.apache.httpcomponents</groupId>
<artifactId>httpclient</artifactId>
- <version>4.5.9</version>
+ <version>4.5.13</version>
Review comment:
same comment as for flink-s3-fs-presto
##########
File path: flink-filesystems/flink-s3-fs-hadoop/src/main/resources/META-INF/NOTICE
##########
@@ -30,7 +30,7 @@ This project bundles the following dependencies under the Apache Software Licens
- org.apache.hadoop:hadoop-common:3.1.0
- org.apache.htrace:htrace-core4:4.1.0-incubating
- org.apache.httpcomponents:httpcore:4.4.6
Review comment:
why are we not bumping httpcore as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org