You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/05/19 16:07:42 UTC
[GitHub] [solr] kiranchitturi opened a new pull request, #870: Solr 16199 fix like
kiranchitturi opened a new pull request, #870:
URL: https://github.com/apache/solr/pull/870
https://issues.apache.org/jira/browse/SOLR-16199
# Description
Adding some more unit tests for LIKE clauses against text analyzed fields
# Solution
only invoke the {!complexphrase} parser if the LIKE clause contains multiple terms and wildcards
also correctly handle escaped wildcard characters % and _
add tests for LIKE clauses against text analyzed fields vs. just strings
# Tests
new tests added in this PR
# Checklist
Please review the following and check all that apply:
- [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [ ] I have created a Jira issue and added the issue ID to my pull request title.
- [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [ ] I have developed this patch against the `main` branch.
- [ ] I have run `./gradlew check`.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Reference Guide](https://github.com/apache/solr/tree/main/solr/solr-ref-guide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] thelabdude merged pull request #870: SOLR-16199: Improve handling of LIKE queries with wildcard
Posted by GitBox <gi...@apache.org>.
thelabdude merged PR #870:
URL: https://github.com/apache/solr/pull/870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] madrob commented on pull request #870: SOLR-16199: Improve handling of LIKE queries with wildcard
Posted by GitBox <gi...@apache.org>.
madrob commented on PR #870:
URL: https://github.com/apache/solr/pull/870#issuecomment-1131986359
Thanks for iterating on this, the escaping logic looks much cleaner now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org