You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "anchao (via GitHub)" <gi...@apache.org> on 2023/03/21 14:24:43 UTC
[GitHub] [nuttx] anchao opened a new pull request, #8866: arm/chip/sdio/muxbus: remove all undefined symbols
anchao opened a new pull request, #8866:
URL: https://github.com/apache/nuttx/pull/8866
remove all undefined symbols to avoid build break if CONFIG_SDIO_MUXBUS enabled
## Summary
arm/chip/sdio/muxbus: remove all undefined symbols
remove all undefined symbols to avoid build break if CONFIG_SDIO_MUXBUS enabled
## Impact
N/A
## Testing
enable CONFIG_SDIO_MUXBUS in photon/wlan :
```bash
chip/stm32_sdio.c: In function 'stm32_lock':
chip/stm32_sdio.c:1583:3: warning: implicit declaration of function 'stm32_muxbus_sdio_lock' [-Wimplicit-function-declaration]
1583 | stm32_muxbus_sdio_lock(lock);
| ^~~~~~~~~~~~~~~~~~~~~~
LD: nuttx
arm-none-eabi-ld: /home/archer/code/nuttx/n9/incubator-nuttx/staging/libarch.a(stm32_sdio.o): in function `stm32_lock':
stm32_sdio.c:(.text.stm32_lock+0x4): undefined reference to `stm32_muxbus_sdio_lock'
make[1]: *** [Makefile:187: nuttx] Error 1
make: *** [tools/Unix.mk:520: nuttx] Error 2
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis commented on pull request #8866: arm/chip/sdio/muxbus: remove all undefined symbols
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #8866:
URL: https://github.com/apache/nuttx/pull/8866#issuecomment-1478325724
@anchao instead of removing these xxxx_muxbus_sdio_lock(), just create an empty definition and add a FIXME message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] acassis merged pull request #8866: arm/chip/sdio/muxbus: remove all undefined symbols
Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis merged PR #8866:
URL: https://github.com/apache/nuttx/pull/8866
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] anchao commented on pull request #8866: arm/chip/sdio/muxbus: remove all undefined symbols
Posted by "anchao (via GitHub)" <gi...@apache.org>.
anchao commented on PR #8866:
URL: https://github.com/apache/nuttx/pull/8866#issuecomment-1478880856
> @anchao instead of removing these xxxx_muxbus_sdio_lock(), just create an empty definition and add a FIXME message
Done, @acassis I comment all undefined symbols and add FIXME message before it, I think it is better to keeping empty function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org