You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/03/11 00:58:18 UTC

[GitHub] [kylin] xiacongling commented on a change in pull request #1605: KYLIN-4929 skip update metrics for queries that hit no realization

xiacongling commented on a change in pull request #1605:
URL: https://github.com/apache/kylin/pull/1605#discussion_r591989356



##########
File path: server-base/src/main/java/org/apache/kylin/rest/metrics/QueryMetricsFacade.java
##########
@@ -84,6 +84,9 @@ private static void updateMetricsToLocal(SQLRequest sqlRequest, SQLResponse sqlR
         update(getQueryMetrics(projectName), sqlResponse);
 
         String cube = sqlResponse.getCube();
+        if (cube == null) {

Review comment:
       updated.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org