You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@jmeter.apache.org by bu...@apache.org on 2013/09/11 20:01:32 UTC

[Bug 55548] New: Tidy up use of TestElement.ENABLED; use ATE.isEnabled()/setEnabled() throughout

https://issues.apache.org/bugzilla/show_bug.cgi?id=55548

            Bug ID: 55548
           Summary: Tidy up use of TestElement.ENABLED; use
                    ATE.isEnabled()/setEnabled() throughout
           Product: JMeter
           Version: 2.9
          Hardware: PC
                OS: Windows XP
            Status: NEW
          Severity: minor
          Priority: P2
         Component: Main
          Assignee: issues@jmeter.apache.org
          Reporter: sebb@apache.org

public void setEnabled(boolean enabled) was added to AbstractTestElement (for
use by ProxyControl); it should also be added to the interface TestElement.

Then it can be used elsewhere.

There are also various uses of code like:

if (component.getProperty(TestElement.ENABLED) instanceof NullProperty
 || component.getPropertyAsBoolean(TestElement.ENABLED)) {
}

This is exactly what AbstractTestElement.isEnabled() does, so the code could be
simplifed to:

if (component.isEnabled()) {
}

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55548] Tidy up use of TestElement.ENABLED; use TestElement.isEnabled()/setEnabled() throughout

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55548

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from Sebb <se...@apache.org> ---
URL: http://svn.apache.org/r1521971
Log:
Tidy up use of TestElement.ENABLED; use TestElement.isEnabled()/setEnabled()
throughout
Bugzilla Id: 55548

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/gui/AbstractJMeterGuiComponent.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeModel.java
    jmeter/trunk/src/core/org/apache/jmeter/gui/tree/JMeterTreeNode.java
   
jmeter/trunk/src/core/org/apache/jmeter/testelement/AbstractTestElement.java
    jmeter/trunk/src/core/org/apache/jmeter/testelement/TestElement.java
   
jmeter/trunk/src/reports/org/apache/jmeter/report/gui/tree/ReportTreeModel.java
   
jmeter/trunk/src/reports/org/apache/jmeter/report/gui/tree/ReportTreeNode.java
    jmeter/trunk/xdocs/changes.xml

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 55548] Tidy up use of TestElement.ENABLED; use TestElement.isEnabled()/setEnabled() throughout

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=55548

Sebb <se...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|Tidy up use of              |Tidy up use of
                   |TestElement.ENABLED; use    |TestElement.ENABLED; use
                   |ATE.isEnabled()/setEnabled( |TestElement.isEnabled()/set
                   |) throughout                |Enabled() throughout

-- 
You are receiving this mail because:
You are the assignee for the bug.