You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "alpha-baby (via GitHub)" <gi...@apache.org> on 2023/04/26 11:28:12 UTC
[GitHub] [dubbo-go-hessian2] alpha-baby opened a new issue, #360: 单测里面使用 log.Fatal 会使得单测直接通过
alpha-baby opened a new issue, #360:
URL: https://github.com/apache/dubbo-go-hessian2/issues/360
https://github.com/apache/dubbo-go-hessian2/blob/7231dc56dfe9384a1e41f0b76bf48aae125f338e/decode_test.go#L84
```golang
func TestDemo(t *testing.T) {
log.Fatal()
t.Errorf("unit test fail")
}
```
这个例子就直接让单测通过了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on issue #360: 单测里面使用 log.Fatal 会使得单测直接通过
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks commented on issue #360:
URL: https://github.com/apache/dubbo-go-hessian2/issues/360#issuecomment-1537056789
@wongoo after we merge your latest pr, could we close this issue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks closed issue #360: 单测里面使用 log.Fatal 会使得单测直接通过
Posted by "AlexStocks (via GitHub)" <gi...@apache.org>.
AlexStocks closed issue #360: 单测里面使用 log.Fatal 会使得单测直接通过
URL: https://github.com/apache/dubbo-go-hessian2/issues/360
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] tiltwind commented on issue #360: 单测里面使用 log.Fatal 会使得单测直接通过
Posted by "tiltwind (via GitHub)" <gi...@apache.org>.
tiltwind commented on issue #360:
URL: https://github.com/apache/dubbo-go-hessian2/issues/360#issuecomment-1537058881
> @wongoo after we merge your latest pr, could we close this issue?
I think we can close it .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] tiltwind commented on issue #360: 单测里面使用 log.Fatal 会使得单测直接通过
Posted by "tiltwind (via GitHub)" <gi...@apache.org>.
tiltwind commented on issue #360:
URL: https://github.com/apache/dubbo-go-hessian2/issues/360#issuecomment-1537058796
In fact, the unit test will fail for process exit.
```go
func TestDemo(t *testing.T) {
log.Fatal()
t.Errorf("unit test fail")
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org