You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Jiabao Sun (Jira)" <ji...@apache.org> on 2023/09/15 09:19:00 UTC

[jira] [Commented] (FLINK-32445) BlobStore.closeAndCleanupAllData doesn't do any close action

    [ https://issues.apache.org/jira/browse/FLINK-32445?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17765517#comment-17765517 ] 

Jiabao Sun commented on FLINK-32445:
------------------------------------

Hi [~mapohl], I just submit a PR of this issue.
If you have time, could you please help review it?

> BlobStore.closeAndCleanupAllData doesn't do any close action
> ------------------------------------------------------------
>
>                 Key: FLINK-32445
>                 URL: https://issues.apache.org/jira/browse/FLINK-32445
>             Project: Flink
>          Issue Type: Technical Debt
>          Components: Runtime / Coordination
>    Affects Versions: 1.18.0
>            Reporter: Matthias Pohl
>            Priority: Minor
>              Labels: auto-deprioritized-major, pull-request-available, starter
>
> We might want to refactor {{BlobStore.closeAndCleanupAllData}}: It doesn't close any resources (and doesn't need to). Therefore, renaming the interfaces method to {{cleanAllData}} seems to be more appropriate.
> This enables us to remove redundant code in {{AbstractHaServices.closeAndCleanupAllData}} and {{AbstractHaServices.close}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)