You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@freemarker.apache.org by dd...@apache.org on 2020/08/01 23:02:13 UTC
[freemarker-docgen] branch master updated (7414ae8 -> a3497de)
This is an automated email from the ASF dual-hosted git repository.
ddekany pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/freemarker-docgen.git.
from 7414ae8 Always show "bookmarks" next to the breadcrumbs. Other adjustments in that row.
new 56bad79 Fixed Docbook table width issue on mobile
new a3497de Made accurately tapping on mobile easier at some parts
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
.../docgen/core/less/lib/components/bookmarks.less | 6 +++++-
.../docgen/core/less/lib/components/breadcrumb.less | 6 +++++-
.../docgen/core/less/lib/components/page-menu.less | 5 +++++
.../docgen/core/less/lib/components/table.less | 18 +++++-------------
.../freemarker/docgen/core/less/lib/layout/header.less | 14 ++++++++++----
.../org/freemarker/docgen/core/less/lib/utilities.less | 2 +-
6 files changed, 31 insertions(+), 20 deletions(-)
[freemarker-docgen] 02/02: Made accurately tapping on mobile easier
at some parts
Posted by dd...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ddekany pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/freemarker-docgen.git
commit a3497de21c8175de82327cf439af4a7dfcd2fa88
Author: ddekany <dd...@apache.org>
AuthorDate: Sun Aug 2 01:01:48 2020 +0200
Made accurately tapping on mobile easier at some parts
---
.../docgen/core/less/lib/components/bookmarks.less | 6 +++++-
.../docgen/core/less/lib/components/breadcrumb.less | 6 +++++-
.../docgen/core/less/lib/components/page-menu.less | 5 +++++
.../org/freemarker/docgen/core/less/lib/layout/header.less | 14 ++++++++++----
.../org/freemarker/docgen/core/less/lib/utilities.less | 2 +-
5 files changed, 26 insertions(+), 7 deletions(-)
diff --git a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/bookmarks.less b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/bookmarks.less
index 2c09b84..145116e 100644
--- a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/bookmarks.less
+++ b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/bookmarks.less
@@ -20,7 +20,11 @@
overflow: hidden;
white-space: nowrap;
- padding-top: @breadcrumb-row-padding-top;
+ @media (min-width: @screen-xs-min) {
+ // For smaller screens increased .breadcrumb-row line height will make up for this
+ padding-top: @breadcrumb-row-padding-top;
+ }
+
font-size: @breadcrumb-row-font-size-xs;
@media (min-width: @screen-xs-min) {
font-size: @breadcrumb-row-font-size-sm;
diff --git a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/breadcrumb.less b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/breadcrumb.less
index 1d6495d..458a10b 100644
--- a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/breadcrumb.less
+++ b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/breadcrumb.less
@@ -17,7 +17,11 @@
* under the License.
*/
.breadcrumbs {
- padding-top: @breadcrumb-row-padding-top;
+ @media (min-width: @screen-xs-min) {
+ // For smaller screens increased .breadcrumb-row line height will make up for this
+ padding-top: @breadcrumb-row-padding-top;
+ }
+
// Right padding is the spacing between .breadcrumbs and .bookmarks (this works as overflow is hidden)
padding-right: 1.5em;
white-space: nowrap;
diff --git a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/page-menu.less b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/page-menu.less
index 49a0602..7b55231 100644
--- a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/page-menu.less
+++ b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/page-menu.less
@@ -40,6 +40,11 @@
ul {
margin: 0 0 0 18px;
padding: 0;
+
+ line-height: 2.5;
+ @media (min-width: @screen-xs-min) {
+ line-height: 1.5;
+ }
}
a {
diff --git a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/layout/header.less b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/layout/header.less
index 2a7cecd..6941237 100644
--- a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/layout/header.less
+++ b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/layout/header.less
@@ -91,18 +91,24 @@
}
.breadcrumb-row {
- padding-top: 9px; // increase padding when search row doesn't exist
+ // Mobile view:
+ padding-top: 6px;
+ // Non-mobile view:
+ @media (min-width: @screen-xs-min) {
+ padding-top: 0; // increase padding when search row doesn't exist
+ }
+
padding-bottom: 9px;
- .search-row + & {
- padding-top: 0;
- }
+ // Mobile view has small font here
+ line-height: 2.5;
@media (min-width: @screen-xs-min) {
display: flex;
justify-content: space-between;
flex-wrap: wrap;
align-items: flex-end;
+ line-height: 1.5;
}
}
diff --git a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/utilities.less b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/utilities.less
index 84fa9f4..308b12c 100644
--- a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/utilities.less
+++ b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/utilities.less
@@ -18,7 +18,7 @@
*/
// determines the max-width of the site at various resolutions
.site-width {
- padding-left: @gutter-width / 4 * 3; // 18px
+ padding-left: @gutter-width / 4 * 3;
padding-right: @gutter-width / 4 * 3;
@media (min-width: @screen-sm-min) {
[freemarker-docgen] 01/02: Fixed Docbook table width issue on mobile
Posted by dd...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ddekany pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/freemarker-docgen.git
commit 56bad79aeaa3bd409d8e212b43b765b702c92aef
Author: ddekany <dd...@apache.org>
AuthorDate: Sat Aug 1 23:33:44 2020 +0200
Fixed Docbook table width issue on mobile
---
.../docgen/core/less/lib/components/table.less | 18 +++++-------------
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/table.less b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/table.less
index b15ff24..aa25554 100644
--- a/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/table.less
+++ b/freemarker-docgen-core/src/main/resources-gulp/org/freemarker/docgen/core/less/lib/components/table.less
@@ -18,10 +18,13 @@
*/
.table-responsive {
min-height: .01%;
+
+ /* To prevent the the table stretching the width of its parent, and become scrollable instead: */
+ width: 0;
+ min-width: 100%;
overflow-x: auto;
@media (max-width: @screen-xs-max) {
- width: 100%;
margin-bottom: 15px;
overflow-y: hidden;
-ms-overflow-style: -ms-autohiding-scrollbar;
@@ -36,14 +39,12 @@
border: 1px solid #ddd;
width: 100%;
- max-width: 100%;
th {
font-weight: 500;
text-align: left;
background-color: #f9f9f9;
border-bottom: 1px solid #ddd;
- white-space: nowrap;
}
th,
@@ -53,17 +54,8 @@
vertical-align: top;
}
- td {
- // dont wrap whitespace for smaller screens
- // since tables are going to scroll anyway
- white-space: nowrap;
-
- @media (min-width: @screen-md-min) {
- white-space: normal;
- }
- }
-
a {
+ // We don't want to break mid-word, as a-only cells might become 1 char wide...
word-break: normal;
}
}