You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2019/12/21 18:27:21 UTC
[GitHub] [camel-quarkus] ppalaga opened a new pull request #569: Fix #568
Untrack Artemis test instance data
ppalaga opened a new pull request #569: Fix #568 Untrack Artemis test instance data
URL: https://github.com/apache/camel-quarkus/pull/569
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli merged pull request #569: Fix #568
Untrack Artemis test instance data
Posted by GitBox <gi...@apache.org>.
lburgazzoli merged pull request #569: Fix #568 Untrack Artemis test instance data
URL: https://github.com/apache/camel-quarkus/pull/569
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #569:
Fix #568 Untrack Artemis test instance data
Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #569: Fix #568 Untrack Artemis test instance data
URL: https://github.com/apache/camel-quarkus/pull/569#discussion_r360666871
##########
File path: integration-tests/sjms/src/test/java/org/apache/camel/quarkus/component/sjms/it/CamelSjmsTestResource.java
##########
@@ -41,14 +42,16 @@ public void inject(Object testInstance) {
@Override
public Map<String, String> start() {
try {
- FileUtils.deleteDirectory(Paths.get("./target/artemis").toFile());
+ final File dataDirectory = Paths.get("./target/artemis").toFile();
+ FileUtils.deleteDirectory(dataDirectory);
Review comment:
A reason for keeping it after the test could be that sometimes it is handy to be able to inspect the state of a directory like this after the test.
Any reasons for removing it after the test?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request
#569: Fix #568 Untrack Artemis test instance data
Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #569: Fix #568 Untrack Artemis test instance data
URL: https://github.com/apache/camel-quarkus/pull/569#discussion_r360662256
##########
File path: integration-tests/sjms/src/test/java/org/apache/camel/quarkus/component/sjms/it/CamelSjmsTestResource.java
##########
@@ -41,14 +42,16 @@ public void inject(Object testInstance) {
@Override
public Map<String, String> start() {
try {
- FileUtils.deleteDirectory(Paths.get("./target/artemis").toFile());
+ final File dataDirectory = Paths.get("./target/artemis").toFile();
+ FileUtils.deleteDirectory(dataDirectory);
Review comment:
shouldn’t this be done also when the test ends?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services