[GitHub] [incubator-nuttx] gustavonihei edited a comment on pull request #4487: arch/sim: Don't add -lc++abi to STDLIBS

[GitBox <gi...@apache.org>]

gustavonihei edited a comment on pull request #4487:
URL: https://github.com/apache/incubator-nuttx/pull/4487#issuecomment-920254161


   I've noticed that our CI does not build `libc++` in any of the selected configurations. Actually `cxxtest` is skipped on `macOS`.
   
   So I've tried building it locally on macOS Big Sur and I couldn't get `libcxx` to build `libcxxtest` defconfig. The `cxxtest` defconfig also fails when changing the C++ library to libcxx.
   
   Relevant information: it is also failing on **master**, so it is not strictly related to this PR.
   
   This is one the errors:
   
   ```bash
   In file included from ./cxxtest_main.cxx:28:
   In file included from /Users/nihei/Projects/NuttX/nuttx/include/libcxx/fstream:183:
   /Users/nihei/Projects/NuttX/nuttx/include/libcxx/__availability:187:5: error: "It looks like you're trying to enable vendor availability markup, but you haven't defined the
         corresponding macros yet!"
   #   error "It looks like you're trying to enable vendor availability markup, but you haven't defined the corresponding macros yet!"
       ^
   1 error generated.
   ERROR: c++ failed: 1
          command: c++ -MT ./cxxtest_main.cxx.Users.nihei.Projects.NuttX.apps.testing.cxxtest.o  -M '-Wall' '-Wshadow' '-Wundef' '-g' '-fno-builtin' '-nostdinc++' '-fvisibility=hidden' '-fno-common' '-isystem' '/Users/nihei/Projects/NuttX/nuttx/include/libcxx' '-isystem' '/Users/nihei/Projects/NuttX/nuttx/include' '-D__NuttX__' '-U_AIX' '-U_WIN32' '-U__APPLE__' '-U__FreeBSD__' '-U__NetBSD__' '-U__linux__' '-U__sun__' '-U__unix__' '-D__KERNEL__' '-pipe' '-fshort-wchar' '-std=c++17' '-DLIBCXX_BUILDING_LIBCXXABI' '-I' '/Users/nihei/Projects/NuttX/apps/include' ./cxxtest_main.cxx
   ```
   
   I've tried the following patch, but to no success:
   ```patch
   diff --git a/libs/libxx/libcxxmini.defs b/libs/libxx/libcxxmini.defs
   index 2624a4534c..4e780e303a 100644
   --- a/libs/libxx/libcxxmini.defs
   +++ b/libs/libxx/libcxxmini.defs
   @@ -35,5 +35,7 @@ ifneq ($(CONFIG_XTENSA_TOOLCHAIN_XCC), y)
      libxx_newa.cxx_CXXFLAGS += -Wno-missing-exception-spec
    endif
   
   +CXXFLAGS += ${shell $(DEFINE) "$(CC)" _LIBCXXABI_BUILDING_LIBRARY}
   +
    DEPPATH += --dep-path libcxxmini
    VPATH += libcxxmini
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org