You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WillAyd (via GitHub)" <gi...@apache.org> on 2025/04/16 12:40:53 UTC
[PR] GH46157: [C++] Disable util test when ARROW_COMPUTE=OFF [arrow]
WillAyd opened a new pull request, #46162:
URL: https://github.com/apache/arrow/pull/46162
### Rationale for this change
The test suite currently fails when ARROW_COMPUTE is disabled
### What changes are included in this PR?
This disables the particular util test when ARROW_COMPUTE=OFF
### Are these changes tested?
Yes
### Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46157: [C++] Disable util test when ARROW_COMPUTE=OFF [arrow]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd commented on code in PR #46162:
URL: https://github.com/apache/arrow/pull/46162#discussion_r2046983251
##########
cpp/src/arrow/testing/gtest_util_test.cc:
##########
@@ -292,6 +292,7 @@ TEST(AssertTestWithinUlp, Basics) {
EXPECT_FATAL_FAILURE(AssertWithinUlp(123.456f, 123.456085f, 10), "not within 10 ulps");
}
+#ifdef ARROW_COMPUTE
Review Comment:
Ah that's great - thanks for taking a look! I agree your solution is more robust - let's roll with that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46157: [C++] Disable util test when ARROW_COMPUTE=OFF [arrow]
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on code in PR #46162:
URL: https://github.com/apache/arrow/pull/46162#discussion_r2046952253
##########
cpp/src/arrow/testing/gtest_util_test.cc:
##########
@@ -292,6 +292,7 @@ TEST(AssertTestWithinUlp, Basics) {
EXPECT_FATAL_FAILURE(AssertWithinUlp(123.456f, 123.456085f, 10), "not within 10 ulps");
}
+#ifdef ARROW_COMPUTE
Review Comment:
while this might solve the specific test failure, I think the underlying problem is not solved.
`gtest_util.cc` is build if `ARROW_TESTING=ON`, it should not require run_end_encode as that requires `ARROW_COMPUTE`.
In my opinion the `RunEndEncodeTableColumns` function should be part of test utilities from `arrow::compute`, I created a PR for that:
https://github.com/apache/arrow/pull/46161
This also appears on other issues as the one found here:
https://github.com/apache/arrow/pull/45618/files#diff-8e690315a407919d147f16a9a534fc9f5c3f6345b58820e2057afa7cd14bea6bR741
were I had to add run_end_encode to the non-conditional sources that are always included as part of libarrow as a workaround.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH46157: [C++] Disable util test when ARROW_COMPUTE=OFF [arrow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #46162:
URL: https://github.com/apache/arrow/pull/46162#issuecomment-2809463635
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose
Opening GitHub issues ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename the pull request title in the following format?
GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - Contributing Overview](https://arrow.apache.org/docs/developers/overview.html)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] GH-46157: [C++] Disable util test when ARROW_COMPUTE=OFF [arrow]
Posted by "WillAyd (via GitHub)" <gi...@apache.org>.
WillAyd closed pull request #46162: GH-46157: [C++] Disable util test when ARROW_COMPUTE=OFF
URL: https://github.com/apache/arrow/pull/46162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org