You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2021/04/14 06:45:25 UTC

[GitHub] [sling-org-apache-sling-feature-cpconverter] kwin commented on a change in pull request #70: SLING-10127 optionally emit converted content packages to dedicated folder

kwin commented on a change in pull request #70:
URL: https://github.com/apache/sling-org-apache-sling-feature-cpconverter/pull/70#discussion_r612978397



##########
File path: src/main/java/org/apache/sling/feature/cpconverter/artifacts/LocalMavenRepositoryArtifactsDeployer.java
##########
@@ -99,4 +92,17 @@ public void deploy(@NotNull ArtifactWriter artifactWriter, @NotNull ArtifactId i
         }
     }
 
+    public static String getNameFromArtifactId(ArtifactId id) {
+        StringBuilder nameBuilder = new StringBuilder()

Review comment:
       I just extracted the existing code into a new method, but even better to reuse the one from `ArtifactId`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org