You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/11/06 11:06:45 UTC

Review Request 71719: Updated 'getResourceConversion()' for reservation updates.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71719/
-----------------------------------------------------------

Review request for mesos.


Repository: mesos


Description
-------

Updated the `getResourcesConversion()` function to correctly
handle the `source` field in `RESERVE` operations.


Diffs
-----

  src/common/resources_utils.cpp 5e78997fb9673faec37f20566d06328fe347b7e1 


Diff: https://reviews.apache.org/r/71719/diff/1/


Testing
-------


Thanks,

Benno Evers

Re: Review Request 71719: Updated 'getResourceConversion()' for reservation updates.

Posted by Benjamin Bannier <bb...@apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71719/#review218536
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Bannier


On Nov. 6, 2019, 12:06 p.m., Benno Evers wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71719/
> -----------------------------------------------------------
> 
> (Updated Nov. 6, 2019, 12:06 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated the `getResourcesConversion()` function to correctly
> handle the `source` field in `RESERVE` operations.
> 
> 
> Diffs
> -----
> 
>   src/common/resources_utils.cpp 5e78997fb9673faec37f20566d06328fe347b7e1 
> 
> 
> Diff: https://reviews.apache.org/r/71719/diff/1/
> 
> 
> Testing
> -------
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>