You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "ZhangYao (Code Review)" <ge...@cloudera.org> on 2019/07/10 11:37:58 UTC
[kudu-CR] Separate benchmark to single test
ZhangYao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13832
Change subject: Separate benchmark to single test
......................................................................
Separate benchmark to single test
Separate the total benchmark to single test with paraments so
they all can be run in test time limit.
Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
---
M src/kudu/common/CMakeLists.txt
M src/kudu/common/wire_protocol-test.cc
2 files changed, 12 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/13832/1
--
To view, visit http://gerrit.cloudera.org:8080/13832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
Gerrit-Change-Number: 13832
Gerrit-PatchSet: 1
Gerrit-Owner: ZhangYao <tr...@gmail.com>
[kudu-CR] Separate benchmark to single test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13832 )
Change subject: Separate benchmark to single test
......................................................................
Patch Set 1:
(1 comment)
How slow are these tests in DEBUG mode?
http://gerrit.cloudera.org:8080/#/c/13832/1/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:
http://gerrit.cloudera.org:8080/#/c/13832/1/src/kudu/common/wire_protocol-test.cc@63
PS1, Line 63: class WireProtocolTest : public KuduTest,
Doc up here that the int corresponds to the number of columns and the double to the selection rate.
--
To view, visit http://gerrit.cloudera.org:8080/13832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
Gerrit-Change-Number: 13832
Gerrit-PatchSet: 1
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 10 Jul 2019 14:21:21 +0000
Gerrit-HasComments: Yes
[kudu-CR] Separate benchmark to single test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13832 )
Change subject: Separate benchmark to single test
......................................................................
Separate benchmark to single test
Separate the total benchmark to single test with paraments so
they all can be run in test time limit.
Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
Reviewed-on: http://gerrit.cloudera.org:8080/13832
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon <to...@apache.org>
---
M src/kudu/common/CMakeLists.txt
M src/kudu/common/wire_protocol-test.cc
2 files changed, 14 insertions(+), 14 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
Todd Lipcon: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
Gerrit-Change-Number: 13832
Gerrit-PatchSet: 4
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] Separate benchmark to single test
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13832
to look at the new patch set (#3).
Change subject: Separate benchmark to single test
......................................................................
Separate benchmark to single test
Separate the total benchmark to single test with paraments so
they all can be run in test time limit.
Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
---
M src/kudu/common/CMakeLists.txt
M src/kudu/common/wire_protocol-test.cc
2 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/13832/3
--
To view, visit http://gerrit.cloudera.org:8080/13832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
Gerrit-Change-Number: 13832
Gerrit-PatchSet: 3
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
[kudu-CR] Separate benchmark to single test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13832 )
Change subject: Separate benchmark to single test
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13832/2/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:
http://gerrit.cloudera.org:8080/#/c/13832/2/src/kudu/common/wire_protocol-test.cc@64
PS2, Line 64: /*Used for benchmark, int corresponds to the number of columns,
: * double corresponds to the selection rate.*/
Nit: use C++-style commenting:
// Used for benchmark, int corresponds to the number of columns,
// double corresponds to the selection rate.
--
To view, visit http://gerrit.cloudera.org:8080/13832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
Gerrit-Change-Number: 13832
Gerrit-PatchSet: 2
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Jul 2019 04:55:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] Separate benchmark to single test
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13832 )
Change subject: Separate benchmark to single test
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13832/2/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:
http://gerrit.cloudera.org:8080/#/c/13832/2/src/kudu/common/wire_protocol-test.cc@64
PS2, Line 64: // Used for benchmark, int corresponds to the number of columns,
: // double corresponds to the selection rate.
> Nit: use C++-style commenting:
Done :)
--
To view, visit http://gerrit.cloudera.org:8080/13832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
Gerrit-Change-Number: 13832
Gerrit-PatchSet: 3
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Jul 2019 05:10:25 +0000
Gerrit-HasComments: Yes
[kudu-CR] Separate benchmark to single test
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13832 )
Change subject: Separate benchmark to single test
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
Gerrit-Change-Number: 13832
Gerrit-PatchSet: 3
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Jul 2019 17:07:21 +0000
Gerrit-HasComments: No
[kudu-CR] Separate benchmark to single test
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
ZhangYao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13832 )
Change subject: Separate benchmark to single test
......................................................................
Patch Set 2:
(1 comment)
> (1 comment)
>
> How slow are these tests in DEBUG mode?
If I run with total 3 * 4 test, it will exceed the Jenkins unit test time limit in Debug mode. So I just seperate them and after that if someone want to extend the parameters of benchmark it can also work.
http://gerrit.cloudera.org:8080/#/c/13832/1/src/kudu/common/wire_protocol-test.cc
File src/kudu/common/wire_protocol-test.cc:
http://gerrit.cloudera.org:8080/#/c/13832/1/src/kudu/common/wire_protocol-test.cc@63
PS1, Line 63: class WireProtocolTest : public KuduTest,
> Doc up here that the int corresponds to the number of columns and the doubl
Done :)
--
To view, visit http://gerrit.cloudera.org:8080/13832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
Gerrit-Change-Number: 13832
Gerrit-PatchSet: 2
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Jul 2019 02:44:12 +0000
Gerrit-HasComments: Yes
[kudu-CR] Separate benchmark to single test
Posted by "ZhangYao (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13832
to look at the new patch set (#2).
Change subject: Separate benchmark to single test
......................................................................
Separate benchmark to single test
Separate the total benchmark to single test with paraments so
they all can be run in test time limit.
Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
---
M src/kudu/common/CMakeLists.txt
M src/kudu/common/wire_protocol-test.cc
2 files changed, 14 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/32/13832/2
--
To view, visit http://gerrit.cloudera.org:8080/13832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
Gerrit-Change-Number: 13832
Gerrit-PatchSet: 2
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Separate benchmark to single test
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13832 )
Change subject: Separate benchmark to single test
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13832
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I980234bcdf76a7d2978f49ed59dff21184abf892
Gerrit-Change-Number: 13832
Gerrit-PatchSet: 3
Gerrit-Owner: ZhangYao <tr...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: ZhangYao <tr...@gmail.com>
Gerrit-Comment-Date: Thu, 11 Jul 2019 05:12:06 +0000
Gerrit-HasComments: No