You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/07/17 16:39:27 UTC
[GitHub] [druid] dongjoon-hyun opened a new pull request #11460: Bump commons-io to 2.11.0
dongjoon-hyun opened a new pull request #11460:
URL: https://github.com/apache/druid/pull/11460
Fixes #XXXX.
<!-- Replace XXXX with the id of the issue fixed in this PR. Remove this section if there is no corresponding issue. Don't reference the issue in the title of this pull-request. -->
<!-- If you are a committer, follow the PR action item checklist for committers:
https://github.com/apache/druid/blob/master/dev/committer-instructions.md#pr-and-issue-action-item-checklist-for-committers. -->
### Description
`commons-io` is upgraded to 2.9.0 and reverted via https://github.com/apache/druid/pull/11392 due to https://issues.apache.org/jira/browse/IO-741 .
Since commons-io 2.11.0 fixed IO-741, this PR aims to retry the upgrade.
#### Fixed the bug ...
#### Renamed the class ...
#### Added a forbidden-apis entry ...
<!--
In each section, please describe design decisions made, including:
- Choice of algorithms
- Behavioral aspects. What configuration values are acceptable? How are corner cases and error conditions handled, such as when there are insufficient resources?
- Class organization and design (how the logic is split between classes, inheritance, composition, design patterns)
- Method organization and design (how the logic is split between methods, parameters and return types)
- Naming (class, method, API, configuration, HTTP endpoint, names of emitted metrics)
-->
<!-- It's good to describe an alternative design (or mention an alternative name) for every design (or naming) decision point and compare the alternatives with the designs that you've implemented (or the names you've chosen) to highlight the advantages of the chosen designs and names. -->
<!-- If there was a discussion of the design of the feature implemented in this PR elsewhere (e. g. a "Proposal" issue, any other issue, or a thread in the development mailing list), link to that discussion from this PR description and explain what have changed in your final design compared to your original proposal or the consensus version in the end of the discussion. If something hasn't changed since the original discussion, you can omit a detailed discussion of those aspects of the design here, perhaps apart from brief mentioning for the sake of readability of this PR description. -->
<!-- Some of the aspects mentioned above may be omitted for simple and small changes. -->
<hr>
##### Key changed/added classes in this PR
* `MyFoo`
* `OurBar`
* `TheirBaz`
<hr>
<!-- Check the items by putting "x" in the brackets for the done things. Not all of these items apply to every PR. Remove the items which are not done or not relevant to the PR. None of the items from the checklist below are strictly necessary, but it would be very helpful if you at least self-review the PR. -->
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882707629
@dongjoon-hyun thanks for fixing the CI failure. The one failed looks flaky. I restarted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] dongjoon-hyun commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882873239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #11460:
URL: https://github.com/apache/druid/pull/11460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #11460:
URL: https://github.com/apache/druid/pull/11460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] dongjoon-hyun commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882911866
Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882917146
Thanks @dongjoon-hyun !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] dongjoon-hyun commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882092630
Oh, sure. Thank you, @jihoonson !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] dongjoon-hyun edited a comment on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882141384
There is one integration test failure. Can we re-trigger test?
```
[ERROR] ITIndexerTest.testGetLockedIntervals:335->AbstractIndexerTest.lambda$unloader$0:71->AbstractIndexerTest.unloadAndKillData:91 » Runtime
[INFO]
[ERROR] Tests run: 16, Failures: 1, Errors: 0, Skipped: 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] dongjoon-hyun commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882873239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882917146
Thanks @dongjoon-hyun !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] dongjoon-hyun edited a comment on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882141384
There is one integration test failure. Can we re-trigger test?
```
32357.73 (Compile=openjdk8, Run=openjdk11) batch index integration test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] dongjoon-hyun commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882873239
Thank you, @jihoonson and @suneet-s !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882707629
@dongjoon-hyun thanks for fixing the CI failure. The one failed looks flaky. I restarted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson merged pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
jihoonson merged pull request #11460:
URL: https://github.com/apache/druid/pull/11460
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882707629
@dongjoon-hyun thanks for fixing the CI failure. The one failed looks flaky. I restarted it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] suneet-s commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
suneet-s commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882917146
Thanks @dongjoon-hyun !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] dongjoon-hyun commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-881948506
The failure is the following, but it seems to be irrelevant from this PR.
```
[ERROR] server/src/main/java/org/apache/druid/segment/realtime/firehose/InlineFirehose.java:44 -- The declared exception <code>IOException</code> is never thrown
12965The command "./check_test_suite.py && travis_terminate 0 || docker run --rm -v $(pwd):/project -v ~/.m2:/home/inspect/.m2 ccaominh/intellij-inspect:1.0.0 /project/pom.xml /project/.idea/inspectionProfiles/Druid.xml --levels ERROR --scope JavaInspectionsScope
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] dongjoon-hyun commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882141384
The integration test failure looks irrelevant.
```
32357.73 (Compile=openjdk8, Run=openjdk11) batch index integration test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] jihoonson commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
jihoonson commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882088185
Hi @dongjoon-hyun, thank you for the PR. The change LGTM, but the CI failure seems legit because [IOUtils.lineIterator no longer throws IOException in 2.11](https://github.com/apache/commons-io/blob/rel/commons-io-2.11.0/src/main/java/org/apache/commons/io/IOUtils.java#L1599). Can you please remove it from the `InlineFirehose` constructor? You would probably want to remove it from `InlineFirehoseFactory.connect` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] dongjoon-hyun edited a comment on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun edited a comment on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882141384
There is one integration test failure. Can we re-trigger test?
```
[ERROR] ITIndexerTest.testGetLockedIntervals:335->AbstractIndexerTest.lambda$unloader$0:71->AbstractIndexerTest.unloadAndKillData:91 » Runtime
[ERROR] Tests run: 16, Failures: 1, Errors: 0, Skipped: 0
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] dongjoon-hyun commented on pull request #11460: Bump commons-io to 2.11.0
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #11460:
URL: https://github.com/apache/druid/pull/11460#issuecomment-882893653
All tests passed finally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org