You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ChenSammi (via GitHub)" <gi...@apache.org> on 2026/07/22 14:40:03 UTC
[PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
ChenSammi opened a new pull request, #503:
URL: https://github.com/apache/ozone-site/pull/503
## What changes were proposed in this pull request?
Add branch merge checklist for short-circuit read.
## What is the link to the Apache Jira?
[HDDS-15864](https://issues.apache.org/jira/browse/HDDS-15864)
## How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi merged PR #503:
URL: https://github.com/apache/ozone-site/pull/503
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3647695910
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, and get this result https://docs.google.com/document/d/1xmjCbK4rP287pPN0_iOonnQee6HgwSI3h5hVbtgfu3k/edit?tab=t.0.
+
+Metrics (ContainerLocalOps, local op latencies, local bytes stats) are added in Datanode to observe the runtime state/latency.
+
+## 12. Security considerations
+
+Short-Circuit Read does not introduce any new CLI or admin command.
+
+Short-circuit communication uses a UNIX domain socket (`ozone.domain.socket.path`) between the client and Datanode.
+
+It follows the same [Hadoop Socket Path Security](https://cwiki.apache.org/confluence/spaces/HADOOP2/pages/120730260/SocketPathSecurity) rules as HDFS short-circuit reads.
Review Comment:
agreed we should copy this to our doc site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3647120584
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
Review Comment:
the feature would require topology awareness to maximize locality https://ozone.apache.org/docs/next/administrator-guide/configuration/performance/topology/#optimizing-read-paths
let's update user doc post merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "priyeshkaratha (via GitHub)" <gi...@apache.org>.
priyeshkaratha commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3639992924
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
Review Comment:
@ChenSammi @Gargi-jais11
This [PR](https://github.com/apache/ozone/pull/10829) completely removes the old website and Hugo since it is now unused. So I suggest to use https://ozone.apache.org/docs/next/administrator-guide/configuration/performance/short-circuit-local-reads
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3675649884
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
Review Comment:
Thanks, just approved the PR. This section of the checklist looks good now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3662443276
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, and get this result https://docs.google.com/document/d/1xmjCbK4rP287pPN0_iOonnQee6HgwSI3h5hVbtgfu3k/edit?tab=t.0.
Review Comment:
@errose28 , do you know how we can make this new engine allows words like YCSB and ycloud?
```
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:80:122 - Unknown word (YCSB) -- ozone fs` command and YCSB on a ycloud cluster
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:80:132 - Unknown word (ycloud) -- command and YCSB on a ycloud cluster. Short-circuit
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "Gargi-jais11 (via GitHub)" <gi...@apache.org>.
Gargi-jais11 commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3662695118
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, and get this result https://docs.google.com/document/d/1xmjCbK4rP287pPN0_iOonnQee6HgwSI3h5hVbtgfu3k/edit?tab=t.0.
Review Comment:
@ChenSammi u can add the unknown words coming up in this file `cspell.yaml`. Then the error will be gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "priyeshkaratha (via GitHub)" <gi...@apache.org>.
priyeshkaratha commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3639992924
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
Review Comment:
@ChenSammi @Gargi-jais11
This [PR](https://github.com/apache/ozone/pull/10829) completely removes the old website and Hugo since it is now unused. So I suggest to add Short-Circuit-Read.md also in website.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3654863385
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, and get this result https://docs.google.com/document/d/1xmjCbK4rP287pPN0_iOonnQee6HgwSI3h5hVbtgfu3k/edit?tab=t.0.
+
+Metrics (ContainerLocalOps, local op latencies, local bytes stats) are added in Datanode to observe the runtime state/latency.
+
+## 12. Security considerations
+
+Short-Circuit Read does not introduce any new CLI or admin command.
+
+Short-circuit communication uses a UNIX domain socket (`ozone.domain.socket.path`) between the client and Datanode.
+
+It follows the same [Hadoop Socket Path Security](https://cwiki.apache.org/confluence/spaces/HADOOP2/pages/120730260/SocketPathSecurity) rules as HDFS short-circuit reads.
Review Comment:
https://cwiki.apache.org/confluence/spaces/HADOOP2/pages/120730260/SocketPathSecurity content is included in the design document "Security" section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3658003476
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
Review Comment:
Then this is not correct and was not tested. It is always the newest component's responsibility to handle compatibility, and Datanode layout feature is never communicated to the client so it is impossible for a new client to do anything about this with the current implementation.
If we actually want the new client to do some handling with an old server, the layout feature should be removed and a `DatanodeVersion` needs to be added instead with a check on the client side. However, SCR may not even be enabled on the server side regardless of its version and finalization status, so we would need a transparent fallback anyways. The `DatanodeVersion` would just save a retry as a regular read for the new client case. It looks like a `LayoutFeature` is not required either way since I don't see any downgrade implications.
The two version system is confusing, that's why we've reduced it to a single version in ZDU so this type of thing should be easier to follow going forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3662317885
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, and get this result https://docs.google.com/document/d/1xmjCbK4rP287pPN0_iOonnQee6HgwSI3h5hVbtgfu3k/edit?tab=t.0.
Review Comment:
I already tried convert the image to markdown table first with Cursor. But cursor did not give me a nice table as I expected after several round of interaction, so finally it's converted to png image.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #503:
URL: https://github.com/apache/ozone-site/pull/503#issuecomment-5138371275
Thanks @Gargi-jais11 @priyeshkaratha @errose28 @jojochuang for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3655851690
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, and get this result https://docs.google.com/document/d/1xmjCbK4rP287pPN0_iOonnQee6HgwSI3h5hVbtgfu3k/edit?tab=t.0.
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3655315229
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3647695910
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, and get this result https://docs.google.com/document/d/1xmjCbK4rP287pPN0_iOonnQee6HgwSI3h5hVbtgfu3k/edit?tab=t.0.
+
+Metrics (ContainerLocalOps, local op latencies, local bytes stats) are added in Datanode to observe the runtime state/latency.
+
+## 12. Security considerations
+
+Short-Circuit Read does not introduce any new CLI or admin command.
+
+Short-circuit communication uses a UNIX domain socket (`ozone.domain.socket.path`) between the client and Datanode.
+
+It follows the same [Hadoop Socket Path Security](https://cwiki.apache.org/confluence/spaces/HADOOP2/pages/120730260/SocketPathSecurity) rules as HDFS short-circuit reads.
Review Comment:
agreed, as a TODO item we should copy this to our doc site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3655311457
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
Review Comment:
https://github.com/apache/ozone/pull/10877.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3654840870
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
Review Comment:
It's to avoid a new client talk to an old server. Yes, the new client has fallback mechanism, but it will cost time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3662406226
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
Review Comment:
XceiverClientManager L211.
```
if (OzoneNetUtils.isAddressLocal(addr) &&
dn.getCurrentVersion() >= SHORT_CIRCUIT_READS.toProtoValue()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3646390195
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
Review Comment:
Can you convert the pdf to markdown and re-commit it to the branch? This is better for AI integration.
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
Review Comment:
Why is the layout feature necessary? It looks like this just creates a socket and closes it on shutdown. How would this break on downgrade?
Also it looks like new clients can request short circuit read from an old server it will be ignored. This seems fine since the field is phrased as "request" but that is worth noting in this section too.
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, and get this result https://docs.google.com/document/d/1xmjCbK4rP287pPN0_iOonnQee6HgwSI3h5hVbtgfu3k/edit?tab=t.0.
+
+Metrics (ContainerLocalOps, local op latencies, local bytes stats) are added in Datanode to observe the runtime state/latency.
+
+## 12. Security considerations
+
+Short-Circuit Read does not introduce any new CLI or admin command.
+
+Short-circuit communication uses a UNIX domain socket (`ozone.domain.socket.path`) between the client and Datanode.
+
+It follows the same [Hadoop Socket Path Security](https://cwiki.apache.org/confluence/spaces/HADOOP2/pages/120730260/SocketPathSecurity) rules as HDFS short-circuit reads.
Review Comment:
Do we have a copy of this in our own docs (not a link to the hadoop docs)? Hadoop 2 wiki [is](https://cwiki.apache.org/confluence/spaces/HADOOP2/pages/120730265/Spookysam) [falling](https://cwiki.apache.org/confluence/spaces/HADOOP2/pages/120730264/South+Korea+on+the+issue+of+inter-Korean+summit+reaffirmed+the+principled+stand+of) [apart](https://cwiki.apache.org/confluence/spaces/HADOOP2/pages/120730295/Www.facebook.com) and we should not be directing users there.
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, and get this result https://docs.google.com/document/d/1xmjCbK4rP287pPN0_iOonnQee6HgwSI3h5hVbtgfu3k/edit?tab=t.0.
Review Comment:
This doc isn't very large, we can put its content directly in this file. We should not commit links to google docs which can disappear or lose access to git.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3658032307
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, and get this result https://docs.google.com/document/d/1xmjCbK4rP287pPN0_iOonnQee6HgwSI3h5hVbtgfu3k/edit?tab=t.0.
Review Comment:
Can you convert the images to markdown tables so they show up in text searches and can have their content copied? If google doc's "copy as markdown" doesn't support this then AI should make this easy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #503:
URL: https://github.com/apache/ozone-site/pull/503#issuecomment-5099441110
@errose28 , do you know how we can make this new engine allows words like YCSB and ycloud?
```
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:80:122 - Unknown word (YCSB) -- ozone fs` command and YCSB on a ycloud cluster
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:80:132 - Unknown word (ycloud) -- command and YCSB on a ycloud cluster. Short-circuit
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "jojochuang (via GitHub)" <gi...@apache.org>.
jojochuang commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3663581257
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,113 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://ozone.apache.org/docs/next/administrator-guide/configuration/performance/short-circuit-local-reads/) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, testing short-circuit performance with the `ozone fs` command and YCSB on a ycloud cluster. Short-circuit read was toggled with `ozone.client.read.short-circuit` and `ozone.domain.socket.path`.
Review Comment:
please replace ycloud with "Cloudera's internal test bed"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3666662545
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, and get this result https://docs.google.com/document/d/1xmjCbK4rP287pPN0_iOonnQee6HgwSI3h5hVbtgfu3k/edit?tab=t.0.
Review Comment:
Google docs "copy as markdown" was able to create the markdown tables. They render well in docusaurus too. I've put this and the spelling fix on my fork [here](https://github.com/errose28/ozone-site/commits/scr-merge-checklist-fixed/). You can cherry-pick these into this PR.
Note I added "YCSB" to cspell where previously it was wrapped in code blocks. Although spelling is ignored for code blocks YCSB is not used as code here, and code blocks as headings render badly in docusaurus right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3666662545
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, and get this result https://docs.google.com/document/d/1xmjCbK4rP287pPN0_iOonnQee6HgwSI3h5hVbtgfu3k/edit?tab=t.0.
Review Comment:
Google docs "copy as markdown" converted the images to tables. They render well in docusaurus too. I've put this and the spelling fix on my fork [here](https://github.com/errose28/ozone-site/commits/scr-merge-checklist-fixed/). You can cherry-pick these into this PR.
Note I added "YCSB" to cspell where previously it was wrapped in code blocks. Although spelling is ignored for code blocks YCSB is not used as code here, and code blocks as headings render badly in docusaurus right now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3662406226
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
Review Comment:
> Datanode layout feature is never communicated to the client so it is impossible for a new client to do anything about this with the current implementation
Client knows the Datanode version and checks it.
XceiverClientManager L211.
```
if (OzoneNetUtils.isAddressLocal(addr) &&
dn.getCurrentVersion() >= SHORT_CIRCUIT_READS.toProtoValue()) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3671366148
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
Review Comment:
https://github.com/apache/ozone/pull/10893
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "ChenSammi (via GitHub)" <gi...@apache.org>.
ChenSammi commented on PR #503:
URL: https://github.com/apache/ozone-site/pull/503#issuecomment-5065592376
> Thanks @ChenSammi for the working on the checklist. Please check the inline comment. Also we may need to create followup Jira to fix urls that pointing to feature branch code to master branch after merge.
I plan to merge this patch after feature branch is merged, so URL can be updated later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3658065027
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, and get this result https://docs.google.com/document/d/1xmjCbK4rP287pPN0_iOonnQee6HgwSI3h5hVbtgfu3k/edit?tab=t.0.
+
+Metrics (ContainerLocalOps, local op latencies, local bytes stats) are added in Datanode to observe the runtime state/latency.
+
+## 12. Security considerations
+
+Short-Circuit Read does not introduce any new CLI or admin command.
+
+Short-circuit communication uses a UNIX domain socket (`ozone.domain.socket.path`) between the client and Datanode.
+
+It follows the same [Hadoop Socket Path Security](https://cwiki.apache.org/confluence/spaces/HADOOP2/pages/120730260/SocketPathSecurity) rules as HDFS short-circuit reads.
Review Comment:
Let's update this section to reference our own user or design docs with this content instead of linking to the hadoop wiki.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3666419692
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
+
+It remains inactive until the cluster upgrade is finalized. A global enable/disable switch is provided via ozone.client.read.short-circuit (default: false).
+
+To enable the feature (after finalization), add the following to the client and Datanode ozone-site.xml to enable the feature:
+
+```xml
+<property>
+ <name>ozone.client.read.short-circuit</name>
+ <value>true</value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>Disable or enable the short-circuit local read feature. By default it is disabled.</description>
+</property>
+```
+And the following to the client and Datanode ozone-site.xml, to specify the path of the UNIX domain socket:
+```xml
+<property>
+ <name>ozone.domain.socket.path</name>
+ <value></value>
+ <tag>CLIENT, DATANODE</tag>
+ <description>UNIX domain socket path for co-located client–Datanode short-circuit communication.</description>
+</property>
+```
+
+## 10. Third-party dependencies/License changes
+
+There are no third party dependencies introduced by this feature.
+
+## 11. Performance
+
+The major workflow of Short-Circuit Read is: The client detects a local Datanode replica → opens a UNIX domain socket → sends GetBlock with requestShortCircuitAccess=true → Datanode passes a file descriptor → The client reads block data directly from the local disk via FileChannel.
+
+End-to-end read performance is therefore dominated by local disk I/O, similar to a direct file read, rather than by gRPC data transfer.
+
+A benchmark was run against feature branch HDDS-10685, and get this result https://docs.google.com/document/d/1xmjCbK4rP287pPN0_iOonnQee6HgwSI3h5hVbtgfu3k/edit?tab=t.0.
Review Comment:
+1 to the above, or inline cspell ignores can be added if the word is only relevant for this page. In this case YCSB is probably valid to allow globally in `cspell.yaml`.
The instructions in the contributing guide are also linked from the [CI failure itself](https://github.com/apache/ozone-site/actions/runs/30253328575/job/89936139578):
```
...
CSpell: Files checked: 1347, Issues found: 5 in 1 file.
Checking file names...
CSpell: Files checked: 1, Issues found: 0 in 0 files.
Spell check failed. See CONTRIBUTING.md for help fixing false positive spelling errors:
https://github.com/apache/ozone-site/blob/master/CONTRIBUTING.md#spelling
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-15864. Branch merge checklist for Short Circuit read [ozone-site]
Posted by "errose28 (via GitHub)" <gi...@apache.org>.
errose28 commented on code in PR #503:
URL: https://github.com/apache/ozone-site/pull/503#discussion_r3666377187
##########
docs/08-developer-guide/04-project/01-git/03-feature-branches/03-merged-branches/17-hdds-10685-short-circuit-read.md:
##########
@@ -0,0 +1,91 @@
+# HDDS-10685 : Short-Circuit Read
+
+Epic: [HDDS-10685](https://issues.apache.org/jira/browse/HDDS-10685)
+Feature branch: https://github.com/apache/ozone/tree/HDDS-10685
+
+## 1. Builds/intermittent test failures
+
+There are no intermittent failures specific to the HDDS-10685 branch as of now. During the development, it was ensured all the CI checks were clean prior to every commit merge.
+
+The plan is to run repeated CI checks on the merge commit to master.
+
+## 2. Documentation
+
+[User Documentation](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/feature/Short-Circuit-Read.md) of Short Circuit Read has been added.
+
+## 3. Design, attached the docs
+
+Design document can be found here : [Short Circuit Read Support](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-hdds/docs/content/design/short-circuit-read.md).
+
+## 4. S3 compatibility
+
+N/A, S3 compatibility remains the same. Short Circuit Read only affects the client and DataNode read path.
+
+## 5. Docker-compose / Acceptance tests
+
+New robot test [short-circuit.robot](https://github.com/apache/ozone/blob/HDDS-10685/hadoop-ozone/dist/src/main/smoketest/short-circuit/short-circuit.robot) is being added.
+
+New acceptance tests are added, mainly tests the Short Circuit Read metrics. It does not test fault injection.
+
+## 6. Support of containers / Kubernetes
+
+No addition. No change in existing support.
+
+## 7. Coverage / Code quality
+
+[New Code Coverage](https://sonarcloud.io/summary/new_code?id=hadoop-ozone&branch=HDDS-10685) for Short Circuit Read Support (HDDS-10685) is 80.78%% and [Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=HDDS-10685) is 78.5%.
+[Overall Code Coverage](https://sonarcloud.io/summary/overall?id=hadoop-ozone&branch=master) for master is 78.5%%.
+
+## 8. Build time
+
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/27126447271/job/80056268213) from HDDS-10685 Branch is 9m 59s.
+[Build time for the latest commit](https://github.com/apache/ozone/actions/runs/29915076929/job/88926295859) from the master branch is 10m 43s.
+
+## 9. Possible incompatible changes/used feature flag
+
+Short-circuit read is gated by the non-rolling upgrade framework as HDDSLayoutFeature.SHORT_CIRCUIT_READS (layout version 11).
Review Comment:
Ok this is good but the doc doesn't mention a new `DatanodeVersion` was also added. Looks like action items are:
- Update the doc to mention the new `DatanodeVersion` to handle the new client case.
- Remove the added `HDDSLayoutFeature` from the branch since there doesn't appear to be any downgrade concerns.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org