[jira] [Commented] (AIRFLOW-3191) Fix not being able to specify execution_date when creating dagrun

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16646746#comment-16646746 ] 

ASF GitHub Bot commented on AIRFLOW-3191:
-----------------------------------------

aoen opened a new pull request #4037: [AIRFLOW-3191] Fix not being able to specify execution_date when creating dagrun
URL: https://github.com/apache/incubator-airflow/pull/4037
 
 
   ### Jira
   
   - [X] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-3191
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   Creating a dagrun using the flask web UI is not possible because execution_date is hidden. This is because the column type is actually DATETIME where Flask only has a converter for DateTime (it's the same type, it's a casing issue).
   
   Fix is to add a form override: form_overrides = dict(execution_date=DateTimeField)
   
   ### Description
   
   - [X] Here are some details about my PR, including screenshots of any UI changes:
   
   
   ### Tests
   
   - [X] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   UI change, no tests for it.
   ### Commits
   
   - [X] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [X] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [X] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix not being able to specify execution_date when creating dagrun
> -----------------------------------------------------------------
>
>                 Key: AIRFLOW-3191
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-3191
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: webserver
>    Affects Versions: 1.10.0
>            Reporter: Dan Davydov
>            Assignee: Dan Davydov
>            Priority: Major
>
> Creating a dagrun using the flask web UI is not possible because execution_date is hidden. This is because the column type is actually DATETIME where Flask only has a converter for DateTime (it's the same type, it's a casing issue).
> Fix is to add a form override: form_overrides = dict(execution_date=DateTimeField)
> Only applies to the non-rbac webserver.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)