You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by "saivivek116 (via GitHub)" <gi...@apache.org> on 2024/03/14 21:30:08 UTC
[PR] Fixflaky [tinkerpop]
saivivek116 opened a new pull request, #2523:
URL: https://github.com/apache/tinkerpop/pull/2523
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixflaky [tinkerpop]
Posted by "saivivek116 (via GitHub)" <gi...@apache.org>.
saivivek116 closed pull request #2523: Fixflaky
URL: https://github.com/apache/tinkerpop/pull/2523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixflaky [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2523:
URL: https://github.com/apache/tinkerpop/pull/2523#issuecomment-1998628668
Hi @saivivek116, thanks for the submission. Could you give a quick description of the changes? Was the test flaky simply due to the unpredictable ordering of HashSet elements? What does the new workflow do? I'm not familiar with Non-Dex.
If this is just a case of a HashSet being used in a test should use a LinkedHashSet, I think that the coverage from https://github.com/apache/tinkerpop/blob/master/.github/workflows/build-test.yml is enough.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixflaky [tinkerpop]
Posted by "saivivek116 (via GitHub)" <gi...@apache.org>.
saivivek116 commented on PR #2523:
URL: https://github.com/apache/tinkerpop/pull/2523#issuecomment-1998822127
I apologize for the insufficient details in the PR. I am currently preparing a new pull request with a comprehensive description and all the necessary details to ensure clarity. Thank you for your patience and understanding
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixflaky [tinkerpop]
Posted by "saivivek116 (via GitHub)" <gi...@apache.org>.
saivivek116 commented on PR #2523:
URL: https://github.com/apache/tinkerpop/pull/2523#issuecomment-2000313968
Thank you for your feedback. The workflow I've proposed is primarily designed to automate the steps I've taken to demonstrate that the test method is flaky. However, upon reflection, I realize it may not add significant value in its current form. Therefore, I will proceed to submit a new pull request that excludes the GitHub workflow actions file, focusing solely on the update from HashSet to LinkedHashSet as discussed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fixflaky [tinkerpop]
Posted by "Cole-Greer (via GitHub)" <gi...@apache.org>.
Cole-Greer commented on PR #2523:
URL: https://github.com/apache/tinkerpop/pull/2523#issuecomment-2000094972
No worries, if this is just a matter of swapping the HashSet with a LinkedHashSet, that makes perfect sense to me and I would be happy to merge that right away. If you think that new github workflow adds additional value that our current workflows are missing, that sounds great too, but we will likely need some details of what it's meant to accomplish.
Thanks again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org