You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by greghogan <gi...@git.apache.org> on 2016/10/20 21:28:28 UTC

[GitHub] flink pull request #2670: [FLINK-4204] [gelly] Clean up gelly-examples

GitHub user greghogan opened a pull request:

    https://github.com/apache/flink/pull/2670

    [FLINK-4204] [gelly] Clean up gelly-examples

    Moves drivers into separate package. Adds default main class to print usage listing included classes. Includes documentation for running Gelly examples.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/greghogan/flink 4204_clean_up_gelly_examples

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/2670.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2670
    
----
commit 642267c70f362ce5414838aaddbed0dcd6b60934
Author: Greg Hogan <co...@greghogan.com>
Date:   2016-08-24T15:32:43Z

    [FLINK-4204] [gelly] Clean up gelly-examples
    
    Moves drivers into separate package. Adds default main class to print
    usage listing included classes. Includes documentation for running
    Gelly examples.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2670: [FLINK-4204] [gelly] Clean up gelly-examples

Posted by vasia <gi...@git.apache.org>.

Github user vasia commented on the issue:

    https://github.com/apache/flink/pull/2670
  
    Hi @greghogan,
    I really like the cleanup and new organization!
    Two thoughts:
    - is the plan to add drivers for all library methods?
    - shall we remove the `GraphMetrics` example since there is a better driver?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request #2670: [FLINK-4204] [gelly] Clean up gelly-examples

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/2670


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2670: [FLINK-4204] [gelly] Clean up gelly-examples

Posted by vasia <gi...@git.apache.org>.

Github user vasia commented on the issue:

    https://github.com/apache/flink/pull/2670
  
    +1 and thanks for the benchmarking link!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink issue #2670: [FLINK-4204] [gelly] Clean up gelly-examples

Posted by greghogan <gi...@git.apache.org>.

Github user greghogan commented on the issue:

    https://github.com/apache/flink/pull/2670
  
    I pushed a commit to remove the `GraphMetrics` example.
    
    I think providing drivers for all library methods is both desirable and ambitious. If we like the form and functionality of the current drivers then I'd like to look at consolidating common functionality where possible. We may also be able to put multiple similar algorithms like `JaccardIndex` / `AdamicAdar` / `CommonNeighbors` into the same driver.
    
    I had first removed `TriangleListing` as it's not an algorithm but I added it back due to Facebook's recent benchmarking: https://code.facebook.com/posts/319004238457019/a-comparison-of-state-of-the-art-graph-processing-systems


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---