You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by al...@apache.org on 2017/03/18 02:16:54 UTC
kudu git commit: [java] fixed warnings from maven-checkstyle-plugin
Repository: kudu
Updated Branches:
refs/heads/master 9b52ae148 -> 6e13ede46
[java] fixed warnings from maven-checkstyle-plugin
This patch does not contain any functional changes.
Change-Id: Ib8e5a27b0d0502c2d5cf18753e0b57d523e8c79d
Reviewed-on: http://gerrit.cloudera.org:8080/6424
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/6e13ede4
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/6e13ede4
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/6e13ede4
Branch: refs/heads/master
Commit: 6e13ede46428124d0c323d139f1a506a4ce093dc
Parents: 9b52ae1
Author: Alexey Serbin <as...@cloudera.com>
Authored: Fri Mar 17 18:24:13 2017 -0700
Committer: Alexey Serbin <as...@cloudera.com>
Committed: Sat Mar 18 02:15:54 2017 +0000
----------------------------------------------------------------------
.../mapreduce/tools/IntegrationTestBigLinkedList.java | 4 ++--
.../src/main/java/org/apache/kudu/client/Status.java | 10 ++++++----
.../java/org/apache/kudu/mapreduce/CommandLineParser.java | 1 +
.../org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java | 3 +--
4 files changed, 10 insertions(+), 8 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/6e13ede4/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
----------------------------------------------------------------------
diff --git a/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java b/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
index 0eb1543..6a26340 100644
--- a/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
+++ b/java/kudu-client-tools/src/main/java/org/apache/kudu/mapreduce/tools/IntegrationTestBigLinkedList.java
@@ -534,8 +534,8 @@ public class IntegrationTestBigLinkedList extends Configured implements Tool {
@Override
protected void cleanup(Context context) throws KuduException {
- session.close();
- client.shutdown();
+ session.close();
+ client.shutdown();
}
@Override
http://git-wip-us.apache.org/repos/asf/kudu/blob/6e13ede4/java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
----------------------------------------------------------------------
diff --git a/java/kudu-client/src/main/java/org/apache/kudu/client/Status.java b/java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
index 609d297..c01b956 100644
--- a/java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
+++ b/java/kudu-client/src/main/java/org/apache/kudu/client/Status.java
@@ -18,6 +18,7 @@
package org.apache.kudu.client;
import com.google.common.annotations.VisibleForTesting;
+
import org.apache.kudu.WireProtocol;
import org.apache.kudu.annotations.InterfaceAudience;
import org.apache.kudu.annotations.InterfaceStability;
@@ -34,7 +35,7 @@ public class Status {
// Limit the message size we get from the servers as it can be quite large.
@VisibleForTesting
- static final int MAX_MESSAGE_LENGTH = 32*1024;
+ static final int MAX_MESSAGE_LENGTH = 32 * 1024;
@VisibleForTesting
static final String ABBREVIATION_CHARS = "...";
@VisibleForTesting
@@ -53,10 +54,11 @@ public class Status {
if (msg.length() > MAX_MESSAGE_LENGTH) {
// Truncate the message and indicate that it was abbreviated.
- this.message = msg.substring(0, MAX_MESSAGE_LENGTH - ABBREVIATION_CHARS_LENGTH)
- + ABBREVIATION_CHARS;
- } else
+ this.message = msg.substring(0, MAX_MESSAGE_LENGTH - ABBREVIATION_CHARS_LENGTH) +
+ ABBREVIATION_CHARS;
+ } else {
this.message = msg;
+ }
}
private Status(WireProtocol.AppStatusPB appStatusPB) {
http://git-wip-us.apache.org/repos/asf/kudu/blob/6e13ede4/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/CommandLineParser.java
----------------------------------------------------------------------
diff --git a/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/CommandLineParser.java b/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/CommandLineParser.java
index 5b701ed..55728cb 100644
--- a/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/CommandLineParser.java
+++ b/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/CommandLineParser.java
@@ -18,6 +18,7 @@
package org.apache.kudu.mapreduce;
import org.apache.hadoop.conf.Configuration;
+
import org.apache.kudu.annotations.InterfaceAudience;
import org.apache.kudu.annotations.InterfaceStability;
import org.apache.kudu.client.AsyncKuduClient;
http://git-wip-us.apache.org/repos/asf/kudu/blob/6e13ede4/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
----------------------------------------------------------------------
diff --git a/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java b/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
index 570b464..6c8287e 100644
--- a/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
+++ b/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableMapReduceUtil.java
@@ -30,6 +30,7 @@ import java.util.Set;
import java.util.zip.ZipEntry;
import java.util.zip.ZipFile;
+import com.google.common.base.Preconditions;
import javax.security.auth.Subject;
import org.apache.commons.logging.Log;
@@ -57,8 +58,6 @@ import org.apache.kudu.client.KuduPredicate;
import org.apache.kudu.client.KuduTable;
import org.apache.kudu.client.Operation;
-import com.google.common.base.Preconditions;
-
/**
* Utility class to setup MR jobs that use Kudu as an input and/or output.
*/