You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datafusion.apache.org by ag...@apache.org on 2026/07/28 13:03:35 UTC
(datafusion-comet) branch main updated: refactor: group orphan `spark.comet.explain.*` configs under one prefix (#5026)
This is an automated email from the ASF dual-hosted git repository.
andygrove pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/datafusion-comet.git
The following commit(s) were added to refs/heads/main by this push:
new 2c05a1598f refactor: group orphan `spark.comet.explain.*` configs under one prefix (#5026)
2c05a1598f is described below
commit 2c05a1598f62064e2c93ebb55e0ce4c591b9909f
Author: Andy Grove <ag...@apache.org>
AuthorDate: Tue Jul 28 07:03:29 2026 -0600
refactor: group orphan `spark.comet.explain.*` configs under one prefix (#5026)
---
README.md | 2 +-
benchmarks/pyspark/run_all_benchmarks.sh | 8 ++++----
benchmarks/tpc/engines/comet-iceberg-hashjoin.toml | 2 +-
benchmarks/tpc/engines/comet-iceberg.toml | 2 +-
.../contributor-guide/adding_a_new_operator.md | 2 +-
docs/source/user-guide/latest/iceberg.md | 4 ++--
docs/source/user-guide/latest/installation.md | 4 ++--
.../user-guide/latest/understanding-comet-plans.md | 24 +++++++++++-----------
.../main/scala/org/apache/comet/CometConf.scala | 11 ++++++----
.../apache/comet/CometSparkSessionExtensions.scala | 12 +++++------
.../org/apache/comet/rules/CometExecRule.scala | 4 ++--
.../scala/org/apache/comet/CometCodegenSuite.scala | 2 +-
.../scala/org/apache/comet/CometConfSuite.scala | 22 ++++++++++++++++++++
.../apache/comet/exec/CometWindowExecSuite.scala | 4 ++--
.../scala/org/apache/spark/sql/CometTestBase.scala | 2 +-
15 files changed, 65 insertions(+), 40 deletions(-)
diff --git a/README.md b/README.md
index 1e350424ba..7725a45db6 100644
--- a/README.md
+++ b/README.md
@@ -102,7 +102,7 @@ $SPARK_HOME/bin/spark-shell \
--conf spark.executor.extraClassPath=$COMET_JAR \
--conf spark.plugins=org.apache.spark.CometPlugin \
--conf spark.shuffle.manager=org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager \
- --conf spark.comet.explainFallback.enabled=true \
+ --conf spark.comet.explain.fallback.enabled=true \
--conf spark.memory.offHeap.enabled=true \
--conf spark.memory.offHeap.size=4g
```
diff --git a/benchmarks/pyspark/run_all_benchmarks.sh b/benchmarks/pyspark/run_all_benchmarks.sh
index 81eb044884..7461ef5d5a 100755
--- a/benchmarks/pyspark/run_all_benchmarks.sh
+++ b/benchmarks/pyspark/run_all_benchmarks.sh
@@ -73,8 +73,8 @@ $SPARK_HOME/bin/spark-submit \
--conf spark.comet.enabled=true \
--conf spark.comet.operator.DataWritingCommandExec.allowIncompatible=true \
--conf spark.comet.parquet.write.enabled=true \
- --conf spark.comet.logFallbackReasons.enabled=true \
- --conf spark.comet.explainFallback.enabled=true \
+ --conf spark.comet.explain.fallback.log.enabled=true \
+ --conf spark.comet.explain.fallback.enabled=true \
--conf spark.comet.shuffle.mode=jvm \
--conf spark.comet.exec.shuffle.mode=jvm \
--conf spark.comet.exec.replaceSortMergeJoin=true \
@@ -101,8 +101,8 @@ $SPARK_HOME/bin/spark-submit \
--conf spark.comet.enabled=true \
--conf spark.comet.operator.DataWritingCommandExec.allowIncompatible=true \
--conf spark.comet.parquet.write.enabled=true \
- --conf spark.comet.logFallbackReasons.enabled=true \
- --conf spark.comet.explainFallback.enabled=true \
+ --conf spark.comet.explain.fallback.log.enabled=true \
+ --conf spark.comet.explain.fallback.enabled=true \
--conf spark.comet.exec.shuffle.mode=native \
--conf spark.comet.exec.replaceSortMergeJoin=true \
--conf spark.shuffle.manager=org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager \
diff --git a/benchmarks/tpc/engines/comet-iceberg-hashjoin.toml b/benchmarks/tpc/engines/comet-iceberg-hashjoin.toml
index 84a5333728..421d320131 100644
--- a/benchmarks/tpc/engines/comet-iceberg-hashjoin.toml
+++ b/benchmarks/tpc/engines/comet-iceberg-hashjoin.toml
@@ -38,7 +38,7 @@ driver_class_path = ["$COMET_JAR", "$ICEBERG_JAR"]
"spark.comet.enabled" = "true"
"spark.comet.exec.enabled" = "true"
"spark.comet.scan.icebergNative.enabled" = "true"
-"spark.comet.explainFallback.enabled" = "true"
+"spark.comet.explain.fallback.enabled" = "true"
"spark.sql.catalog.${ICEBERG_CATALOG}" = "org.apache.iceberg.spark.SparkCatalog"
"spark.sql.catalog.${ICEBERG_CATALOG}.type" = "hadoop"
"spark.sql.catalog.${ICEBERG_CATALOG}.warehouse" = "$ICEBERG_WAREHOUSE"
diff --git a/benchmarks/tpc/engines/comet-iceberg.toml b/benchmarks/tpc/engines/comet-iceberg.toml
index 3654f359e3..c924a6bb9a 100644
--- a/benchmarks/tpc/engines/comet-iceberg.toml
+++ b/benchmarks/tpc/engines/comet-iceberg.toml
@@ -37,7 +37,7 @@ driver_class_path = ["$COMET_JAR", "$ICEBERG_JAR"]
"spark.comet.enabled" = "true"
"spark.comet.exec.enabled" = "true"
"spark.comet.scan.icebergNative.enabled" = "true"
-"spark.comet.explainFallback.enabled" = "true"
+"spark.comet.explain.fallback.enabled" = "true"
"spark.sql.catalog.${ICEBERG_CATALOG}" = "org.apache.iceberg.spark.SparkCatalog"
"spark.sql.catalog.${ICEBERG_CATALOG}.type" = "hadoop"
"spark.sql.catalog.${ICEBERG_CATALOG}.warehouse" = "$ICEBERG_WAREHOUSE"
diff --git a/docs/source/contributor-guide/adding_a_new_operator.md b/docs/source/contributor-guide/adding_a_new_operator.md
index de2a73da88..3841d0b555 100644
--- a/docs/source/contributor-guide/adding_a_new_operator.md
+++ b/docs/source/contributor-guide/adding_a_new_operator.md
@@ -598,6 +598,6 @@ if (childOp.isEmpty) {
## Debugging Tips
1. **Enable verbose logging**: Set `spark.comet.explain.format=verbose` to see detailed plan transformations
-2. **Check fallback reasons**: Set `spark.comet.logFallbackReasons.enabled=true` to log why operators fall back to Spark
+2. **Check fallback reasons**: Set `spark.comet.explain.fallback.log.enabled=true` to log why operators fall back to Spark
3. **Verify protobuf**: Add debug prints in Rust to inspect deserialized operators
4. **Use EXPLAIN**: Run `EXPLAIN EXTENDED` on queries to see the physical plan
diff --git a/docs/source/user-guide/latest/iceberg.md b/docs/source/user-guide/latest/iceberg.md
index a8ea6f30ce..125105b9a0 100644
--- a/docs/source/user-guide/latest/iceberg.md
+++ b/docs/source/user-guide/latest/iceberg.md
@@ -43,7 +43,7 @@ $SPARK_HOME/bin/spark-shell \
--conf spark.sql.catalog.spark_catalog.warehouse=/tmp/warehouse \
--conf spark.plugins=org.apache.spark.CometPlugin \
--conf spark.shuffle.manager=org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager \
- --conf spark.comet.explainFallback.enabled=true \
+ --conf spark.comet.explain.fallback.enabled=true \
--conf spark.memory.offHeap.enabled=true \
--conf spark.memory.offHeap.size=2g
```
@@ -128,7 +128,7 @@ $SPARK_HOME/bin/spark-shell \
--conf spark.sql.catalog.rest_cat.warehouse=/tmp/warehouse \
--conf spark.plugins=org.apache.spark.CometPlugin \
--conf spark.shuffle.manager=org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager \
- --conf spark.comet.explainFallback.enabled=true \
+ --conf spark.comet.explain.fallback.enabled=true \
--conf spark.memory.offHeap.enabled=true \
--conf spark.memory.offHeap.size=2g
```
diff --git a/docs/source/user-guide/latest/installation.md b/docs/source/user-guide/latest/installation.md
index ea3cc348bd..2beed42625 100644
--- a/docs/source/user-guide/latest/installation.md
+++ b/docs/source/user-guide/latest/installation.md
@@ -124,7 +124,7 @@ $SPARK_HOME/bin/spark-shell \
--conf spark.executor.extraClassPath=$COMET_JAR \
--conf spark.plugins=org.apache.spark.CometPlugin \
--conf spark.shuffle.manager=org.apache.spark.sql.comet.execution.shuffle.CometShuffleManager \
- --conf spark.comet.explainFallback.enabled=true \
+ --conf spark.comet.explain.fallback.enabled=true \
--conf spark.memory.offHeap.enabled=true \
--conf spark.memory.offHeap.size=4g
```
@@ -141,7 +141,7 @@ Comet will log output similar to:
```shell
INFO core/src/lib.rs: Comet native library version $COMET_VERSION initialized
-WARN CometExecRule: Comet cannot execute some parts of this plan natively (set spark.comet.explainFallback.enabled=false to disable this logging):
+WARN CometExecRule: Comet cannot execute some parts of this plan natively (set spark.comet.explain.fallback.enabled=false to disable this logging):
Execute InsertIntoHadoopFsRelationCommand [COMET: Native support for operator DataWritingCommandExec is disabled. Set spark.comet.parquet.write.enabled=true to enable it.]
+- WriteFiles
+- LocalTableScan [COMET: Native support for operator LocalTableScanExec is disabled. Set spark.comet.exec.localTableScan.enabled=true to enable it.]
diff --git a/docs/source/user-guide/latest/understanding-comet-plans.md b/docs/source/user-guide/latest/understanding-comet-plans.md
index 8eac031540..af603569a0 100644
--- a/docs/source/user-guide/latest/understanding-comet-plans.md
+++ b/docs/source/user-guide/latest/understanding-comet-plans.md
@@ -87,29 +87,29 @@ incompatibility details.
Comet provides five configs for understanding what is happening in a plan.
They serve different purposes and produce output in different places.
-| Config | Output destination | What you see |
-| ---------------------------------------- | ---------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| `spark.comet.explainFallback.enabled` | Driver log (only when fallback) | A WARN with the list of reasons each query stage could not run in Comet. |
-| `spark.comet.logFallbackReasons.enabled` | Driver log | One WARN per fallback reason as it is encountered, without surrounding plan context. |
-| `spark.comet.explainCodegen.enabled` | `ExtendedExplainInfo` / SQL UI | A single `[COMET-INFO: JVM codegen dispatcher: <name1>, <name2>, ...]` segment naming each expression on the operator that was routed through the JVM codegen dispatcher. |
-| `spark.comet.explain.format` | Spark SQL UI (Spark 4.0 and newer) | Annotated plan or fallback-reason list, depending on `verbose` (default) or `fallback` value. |
-| `spark.comet.explain.native.enabled` | Executor logs, per task | The DataFusion plan with metrics, useful for inspecting Rust execution. |
+| Config | Output destination | What you see |
+| ------------------------------------------ | ---------------------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| `spark.comet.explain.fallback.enabled` | Driver log (only when fallback) | A WARN with the list of reasons each query stage could not run in Comet. |
+| `spark.comet.explain.fallback.log.enabled` | Driver log | One WARN per fallback reason as it is encountered, without surrounding plan context. |
+| `spark.comet.explain.codegen.enabled` | `ExtendedExplainInfo` / SQL UI | A single `[COMET-INFO: JVM codegen dispatcher: <name1>, <name2>, ...]` segment naming each expression on the operator that was routed through the JVM codegen dispatcher. |
+| `spark.comet.explain.format` | Spark SQL UI (Spark 4.0 and newer) | Annotated plan or fallback-reason list, depending on `verbose` (default) or `fallback` value. |
+| `spark.comet.explain.native.enabled` | Executor logs, per task | The DataFusion plan with metrics, useful for inspecting Rust execution. |
-### `spark.comet.explainFallback.enabled`
+### `spark.comet.explain.fallback.enabled`
Logs a single WARN listing the reasons each query stage could not be executed
in Comet. Nothing is logged when the entire stage runs in Comet. Useful as a
low-noise check that fallback is or is not happening.
-### `spark.comet.logFallbackReasons.enabled`
+### `spark.comet.explain.fallback.log.enabled`
Logs every fallback reason as it is encountered, one WARN per reason. Use this
when you want to see all reasons, including ones that
-`spark.comet.explainFallback.enabled` may aggregate or omit. The output does
+`spark.comet.explain.fallback.enabled` may aggregate or omit. The output does
not include the surrounding plan, so it is best for accumulating diagnostics
across many queries.
-### `spark.comet.explainCodegen.enabled`
+### `spark.comet.explain.codegen.enabled`
Disabled by default. When enabled, Comet annotates the surrounding Comet
operator (`CometProject`, `CometFilter`, etc.) with a single combined
@@ -130,7 +130,7 @@ Example:
```scala
spark.conf.set("spark.comet.exec.scalaUDF.codegen.enabled", "true")
-spark.conf.set("spark.comet.explainCodegen.enabled", "true")
+spark.conf.set("spark.comet.explain.codegen.enabled", "true")
val df = spark.sql("SELECT hypot(a, b), levenshtein(s1, s2) FROM t")
println(new org.apache.comet.ExtendedExplainInfo()
diff --git a/spark/src/main/scala/org/apache/comet/CometConf.scala b/spark/src/main/scala/org/apache/comet/CometConf.scala
index 958a22cc2b..821897a9dc 100644
--- a/spark/src/main/scala/org/apache/comet/CometConf.scala
+++ b/spark/src/main/scala/org/apache/comet/CometConf.scala
@@ -619,15 +619,17 @@ object CometConf extends ShimCometConf {
.booleanConf
.createWithDefault(false)
- val COMET_LOG_FALLBACK_REASONS: ConfigEntry[Boolean] =
- conf("spark.comet.logFallbackReasons.enabled")
+ val COMET_EXPLAIN_FALLBACK_LOG_ENABLED: ConfigEntry[Boolean] =
+ conf("spark.comet.explain.fallback.log.enabled")
+ .withAlternative("spark.comet.logFallbackReasons.enabled")
.category(CATEGORY_EXEC_EXPLAIN)
.doc("When this setting is enabled, Comet will log warnings for all fallback reasons.")
.booleanConf
.createWithEnvVarOrDefault("ENABLE_COMET_LOG_FALLBACK_REASONS", false)
val COMET_EXPLAIN_FALLBACK_ENABLED: ConfigEntry[Boolean] =
- conf("spark.comet.explainFallback.enabled")
+ conf("spark.comet.explain.fallback.enabled")
+ .withAlternative("spark.comet.explainFallback.enabled")
.category(CATEGORY_EXEC_EXPLAIN)
.doc(
"When this setting is enabled, Comet will provide logging explaining the reason(s) " +
@@ -637,7 +639,8 @@ object CometConf extends ShimCometConf {
.createWithDefault(false)
val COMET_EXPLAIN_CODEGEN_ENABLED: ConfigEntry[Boolean] =
- conf("spark.comet.explainCodegen.enabled")
+ conf("spark.comet.explain.codegen.enabled")
+ .withAlternative("spark.comet.explainCodegen.enabled")
.category(CATEGORY_EXEC_EXPLAIN)
.doc("When enabled, Comet annotates the surrounding Comet operator with a `[COMET-INFO: " +
"JVM codegen dispatcher: <names>]` segment listing every expression it routed through " +
diff --git a/spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala b/spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala
index 202c52b158..c87e927b48 100644
--- a/spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala
+++ b/spark/src/main/scala/org/apache/comet/CometSparkSessionExtensions.scala
@@ -273,9 +273,9 @@ object CometSparkSessionExtensions extends Logging {
/**
* Record a fallback reason on a `TreeNode` (a Spark operator or expression) explaining why
* Comet cannot accelerate it. Reasons recorded here are surfaced in extended explain output
- * (see `ExtendedExplainInfo`) and, when `COMET_LOG_FALLBACK_REASONS` is enabled, logged as
- * warnings. The reasons are also rolled up from child nodes so that the operator that remains
- * in the Spark plan carries the reasons from its converted-away subtree.
+ * (see `ExtendedExplainInfo`) and, when `COMET_EXPLAIN_FALLBACK_LOG_ENABLED` is enabled, logged
+ * as warnings. The reasons are also rolled up from child nodes so that the operator that
+ * remains in the Spark plan carries the reasons from its converted-away subtree.
*
* Call this in any code path where Comet decides not to convert a given node - serde `convert`
* methods returning `None`, unsupported data types, disabled configs, etc. Do not use this for
@@ -311,8 +311,8 @@ object CometSparkSessionExtensions extends Logging {
* contract.
*
* Reasons are accumulated (never overwritten) on the node's `FALLBACK_REASONS` tag and are
- * surfaced in extended explain output. When `COMET_LOG_FALLBACK_REASONS` is enabled, each new
- * reason is also emitted as a warning.
+ * surfaced in extended explain output. When `COMET_EXPLAIN_FALLBACK_LOG_ENABLED` is enabled,
+ * each new reason is also emitted as a warning.
*
* @param node
* The Spark operator or expression that is falling back to Spark.
@@ -327,7 +327,7 @@ object CometSparkSessionExtensions extends Logging {
* `node` with fallback reasons attached (as a side effect on its tag map).
*/
def withFallbackReasons[T <: TreeNode[_]](node: T, info: Set[String], exprs: T*): T = {
- if (CometConf.COMET_LOG_FALLBACK_REASONS.get()) {
+ if (CometConf.COMET_EXPLAIN_FALLBACK_LOG_ENABLED.get()) {
for (reason <- info) {
logWarning(s"Comet cannot accelerate ${node.getClass.getSimpleName} because: $reason")
}
diff --git a/spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala b/spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala
index bd3b92f2cc..fb88482f15 100644
--- a/spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala
+++ b/spark/src/main/scala/org/apache/comet/rules/CometExecRule.scala
@@ -377,8 +377,8 @@ case class CometExecRule(session: SparkSession)
// WriteFilesExec is always wrapped by DataWritingCommandExec (via Spark's V1Writes
// rule); the parent case converts the whole write to CometNativeWriteExec and
// unwraps WriteFilesExec inside convertToComet. Tagging WriteFilesExec here would
- // produce a spurious "WriteFilesExec is not supported" fallback reason (and a
- // warning when COMET_LOG_FALLBACK_REASONS=true) even when the write is fully native.
+ // produce a spurious "WriteFilesExec is not supported" fallback reason (and a warning
+ // when COMET_EXPLAIN_FALLBACK_LOG_ENABLED=true) even when the write is fully native.
op
case _ =>
// The operator was not converted to a Comet plan. Possible reasons for this happening:
diff --git a/spark/src/test/scala/org/apache/comet/CometCodegenSuite.scala b/spark/src/test/scala/org/apache/comet/CometCodegenSuite.scala
index 9e9b60c35e..b197743a3b 100644
--- a/spark/src/test/scala/org/apache/comet/CometCodegenSuite.scala
+++ b/spark/src/test/scala/org/apache/comet/CometCodegenSuite.scala
@@ -164,7 +164,7 @@ class CometCodegenSuite
}
}
- test("explainCodegen.enabled surfaces routed expressions in COMET-INFO") {
+ test("explain.codegen.enabled surfaces routed expressions in COMET-INFO") {
// With the opt-in flag on, `hypot` and `nanvl` (both `CometCodegenDispatch`) roll up
// into one `[COMET-INFO: JVM codegen dispatcher: hypot, nanvl]` line on the
// `CometProject`. With the flag off (default), no such line appears.
diff --git a/spark/src/test/scala/org/apache/comet/CometConfSuite.scala b/spark/src/test/scala/org/apache/comet/CometConfSuite.scala
index 4757dca83f..4ddd882bd5 100644
--- a/spark/src/test/scala/org/apache/comet/CometConfSuite.scala
+++ b/spark/src/test/scala/org/apache/comet/CometConfSuite.scala
@@ -121,4 +121,26 @@ class CometConfSuite extends AnyFunSuite {
assert(CometConf.COMET_FORCE_SHJ.get(conf))
}
+
+ test("COMET_EXPLAIN_CODEGEN_ENABLED reads deprecated explainCodegen.enabled as an alias") {
+ val conf = new SQLConf
+ conf.setConfString("spark.comet.explainCodegen.enabled", "true")
+
+ assert(CometConf.COMET_EXPLAIN_CODEGEN_ENABLED.get(conf))
+ }
+
+ test("COMET_EXPLAIN_FALLBACK_ENABLED reads deprecated explainFallback.enabled as an alias") {
+ val conf = new SQLConf
+ conf.setConfString("spark.comet.explainFallback.enabled", "true")
+
+ assert(CometConf.COMET_EXPLAIN_FALLBACK_ENABLED.get(conf))
+ }
+
+ test(
+ "COMET_EXPLAIN_FALLBACK_LOG_ENABLED reads deprecated logFallbackReasons.enabled as alias") {
+ val conf = new SQLConf
+ conf.setConfString("spark.comet.logFallbackReasons.enabled", "true")
+
+ assert(CometConf.COMET_EXPLAIN_FALLBACK_LOG_ENABLED.get(conf))
+ }
}
diff --git a/spark/src/test/scala/org/apache/comet/exec/CometWindowExecSuite.scala b/spark/src/test/scala/org/apache/comet/exec/CometWindowExecSuite.scala
index 0e6fcf8946..2441cc0fa7 100644
--- a/spark/src/test/scala/org/apache/comet/exec/CometWindowExecSuite.scala
+++ b/spark/src/test/scala/org/apache/comet/exec/CometWindowExecSuite.scala
@@ -49,8 +49,8 @@ class CometWindowExecSuite extends CometTestBase {
CometConf.COMET_EXEC_SHUFFLE_ENABLED.key -> "true",
CometConf.COMET_EXEC_WINDOW_ENABLED.key -> "true",
"spark.comet.operator.WindowExec.allowIncompatible" -> "true",
- "spark.comet.explainFallback.enabled" -> "true",
- "spark.comet.logFallbackReasons.enabled" -> "true",
+ "spark.comet.explain.fallback.enabled" -> "true",
+ "spark.comet.explain.fallback.log.enabled" -> "true",
"spark.comet.exec.localTableScan.enabled" -> "true") {
testFun
}
diff --git a/spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala b/spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala
index 9a59c9c2eb..ac34151d0e 100644
--- a/spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala
+++ b/spark/src/test/scala/org/apache/spark/sql/CometTestBase.scala
@@ -1216,7 +1216,7 @@ abstract class CometTestBase
* "select arr from tbl",
* sqlConf = Seq(
* CometConf.COMET_SCAN_UNSIGNED_SMALL_INT_SAFETY_CHECK.key -> "true",
- * "spark.comet.explainFallback.enabled" -> "false"
+ * "spark.comet.explain.fallback.enabled" -> "false"
* ),
* debugCometDF = df => {
* df.printSchema()
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datafusion.apache.org
For additional commands, e-mail: commits-help@datafusion.apache.org