You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/23 07:22:54 UTC
[GitHub] [spark] wangyum opened a new pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
wangyum opened a new pull request #32309:
URL: https://github.com/apache/spark/pull/32309
### What changes were proposed in this pull request?
This PR improves `Repartition` and `RepartitionByExpr` statistics estimation using child statistics.
### Why are the changes needed?
The current implementation will missing column stat.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Unit test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825687666
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42392/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-860063849
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-861865125
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44356/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825833627
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137863/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #32309:
URL: https://github.com/apache/spark/pull/32309#discussion_r652276215
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/BasicStatsPlanVisitor.scala
##########
@@ -81,9 +81,9 @@ object BasicStatsPlanVisitor extends LogicalPlanVisitor[Statistics] {
ProjectEstimation.estimate(p).getOrElse(fallback(p))
}
- override def visitRepartition(p: Repartition): Statistics = default(p)
+ override def visitRepartition(p: Repartition): Statistics = fallback(p)
Review comment:
For better maintenance, if `BasicStatsPlanVisitor` and `SizeInBytesOnlyStatsPlanVisitor` have the same implementation, then fallback. For example `visitLocalLimit`:
https://github.com/apache/spark/blob/5553429728859472e3babd507163fba6c9fddfb9/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/BasicStatsPlanVisitor.scala#L76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825650969
**[Test build #137863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137863/testReport)** for PR 32309 at commit [`9d4c349`](https://github.com/apache/spark/commit/9d4c3499e5e1fbe13e48d417ff2bcfc5ba214ccd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-861937475
Thank you, @wangyum . Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825593667
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137850/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825453013
**[Test build #137850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137850/testReport)** for PR 32309 at commit [`a010dea`](https://github.com/apache/spark/commit/a010deae47275f435ab56a0b4c6663e334b74842).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-861865125
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/44356/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825592785
**[Test build #137850 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137850/testReport)** for PR 32309 at commit [`a010dea`](https://github.com/apache/spark/commit/a010deae47275f435ab56a0b4c6663e334b74842).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-861845964
Kubernetes integration test unable to build dist.
exiting with code: 1
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/44356/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825487043
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42380/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825678976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825687666
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42392/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #32309:
URL: https://github.com/apache/spark/pull/32309#discussion_r652277352
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/BasicStatsPlanVisitor.scala
##########
@@ -81,9 +81,9 @@ object BasicStatsPlanVisitor extends LogicalPlanVisitor[Statistics] {
ProjectEstimation.estimate(p).getOrElse(fallback(p))
}
- override def visitRepartition(p: Repartition): Statistics = default(p)
+ override def visitRepartition(p: Repartition): Statistics = fallback(p)
Review comment:
Ah, I see. It's trivial and sgtm.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-860063849
**[Test build #139740 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/139740/testReport)** for PR 32309 at commit [`5553429`](https://github.com/apache/spark/commit/5553429728859472e3babd507163fba6c9fddfb9).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825593667
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137850/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825453013
**[Test build #137850 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137850/testReport)** for PR 32309 at commit [`a010dea`](https://github.com/apache/spark/commit/a010deae47275f435ab56a0b4c6663e334b74842).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #32309:
URL: https://github.com/apache/spark/pull/32309
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #32309:
URL: https://github.com/apache/spark/pull/32309#discussion_r652270280
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/statsEstimation/BasicStatsPlanVisitor.scala
##########
@@ -81,9 +81,9 @@ object BasicStatsPlanVisitor extends LogicalPlanVisitor[Statistics] {
ProjectEstimation.estimate(p).getOrElse(fallback(p))
}
- override def visitRepartition(p: Repartition): Statistics = default(p)
+ override def visitRepartition(p: Repartition): Statistics = fallback(p)
Review comment:
Q: we need to fall back into the size-based one instead of just calling `p.child.stats`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825650969
**[Test build #137863 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137863/testReport)** for PR 32309 at commit [`9d4c349`](https://github.com/apache/spark/commit/9d4c3499e5e1fbe13e48d417ff2bcfc5ba214ccd).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825486987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825487043
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42380/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825833627
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137863/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-860078818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-860078818
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-825812726
**[Test build #137863 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137863/testReport)** for PR 32309 at commit [`9d4c349`](https://github.com/apache/spark/commit/9d4c3499e5e1fbe13e48d417ff2bcfc5ba214ccd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #32309: [SPARK-35203][SQL] Improve Repartition statistics estimation
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #32309:
URL: https://github.com/apache/spark/pull/32309#issuecomment-861929011
Looks fine otherwise.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org