You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wilder Rodrigues <wr...@schubergphilis.com> on 2013/11/14 09:03:04 UTC
Review Request 15508: Make sure that if the file does not exist an Exception
is thrown and that once it exists it is also closed after the properties
are loaded.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15508/
-----------------------------------------------------------
Review request for cloudstack and Hugo Trippaers.
Repository: cloudstack-git
Description
-------
Make sure that if the file does not exist an Exception is thrown and that once it exists it is also closed after the properties are loaded.
fix for Coverity bug cv_1125364 Resource leak
The system resource will not be reclaimed and reused, reducing the future availability of the resource.
In org.?apache.?cloudstack.?network.?contrail.?management.?ManagementNetworkGuru.?configure(java.?lang.?String, java.?util.?Map): Leak of a system resource (CWE-404)
Diffs
-----
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java e457023
Diff: https://reviews.apache.org/r/15508/diff/
Testing
-------
A test branch was created, the patch was applied against the branch and a full build was executed. Everything is working fine. The class changed is tested by MockLocalNfsSecondaryStorageResource.
Thanks,
Wilder Rodrigues
Re: Review Request 15508: Make sure that if the file does not exist an
Exception is thrown and that once it exists it is also closed after the
properties are loaded.
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15508/#review29423
-----------------------------------------------------------
Ship it!
commit 7a6751aa770eaf8065864f497bff401012f553ae
Author: wilderrodrigues <wr...@schubegphilis.com>
Date: Thu Nov 14 08:37:02 2013 +0100
Make sure that if the file does not exist an Exception is thrown and that once it exists it is also closed after the properties are loaded.
Signed-off-by: Hugo Trippaers <ht...@schubergphilis.com>
- Hugo Trippaers
On Nov. 25, 2013, 3:32 p.m., Wilder Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15508/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2013, 3:32 p.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Make sure that if the file does not exist an Exception is thrown and that once it exists it is also closed after the properties are loaded.
>
> fix for Coverity bug cv_1125364 Resource leak
> The system resource will not be reclaimed and reused, reducing the future availability of the resource.
> In org.?apache.?cloudstack.?network.?contrail.?management.?ManagementNetworkGuru.?configure(java.?lang.?String, java.?util.?Map): Leak of a system resource (CWE-404)
>
>
> Diffs
> -----
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java e86e98a
>
> Diff: https://reviews.apache.org/r/15508/diff/
>
>
> Testing
> -------
>
> A test branch was created, the patch was applied against the branch and a full build was executed. Everything is working fine. The class changed is tested by MockLocalNfsSecondaryStorageResource.
>
>
> Thanks,
>
> Wilder Rodrigues
>
>
Re: Review Request 15508: Make sure that if the file does not exist an
Exception is thrown and that once it exists it is also closed after the
properties are loaded.
Posted by Wilder Rodrigues <wr...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15508/
-----------------------------------------------------------
(Updated Nov. 25, 2013, 3:32 p.m.)
Review request for cloudstack and Hugo Trippaers.
Changes
-------
Rebasing my patch in order to get the latest changes from Alex Huang
Repository: cloudstack-git
Description
-------
Make sure that if the file does not exist an Exception is thrown and that once it exists it is also closed after the properties are loaded.
fix for Coverity bug cv_1125364 Resource leak
The system resource will not be reclaimed and reused, reducing the future availability of the resource.
In org.?apache.?cloudstack.?network.?contrail.?management.?ManagementNetworkGuru.?configure(java.?lang.?String, java.?util.?Map): Leak of a system resource (CWE-404)
Diffs (updated)
-----
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java e86e98a
Diff: https://reviews.apache.org/r/15508/diff/
Testing
-------
A test branch was created, the patch was applied against the branch and a full build was executed. Everything is working fine. The class changed is tested by MockLocalNfsSecondaryStorageResource.
Thanks,
Wilder Rodrigues
Re: Review Request 15508: Make sure that if the file does not exist an
Exception is thrown and that once it exists it is also closed after the
properties are loaded.
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15508/#review29161
-----------------------------------------------------------
plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java
<https://reviews.apache.org/r/15508/#comment56300>
I'm giving a demo, ignore this
- Hugo Trippaers
On Nov. 14, 2013, 8:03 a.m., Wilder Rodrigues wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15508/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2013, 8:03 a.m.)
>
>
> Review request for cloudstack and Hugo Trippaers.
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Make sure that if the file does not exist an Exception is thrown and that once it exists it is also closed after the properties are loaded.
>
> fix for Coverity bug cv_1125364 Resource leak
> The system resource will not be reclaimed and reused, reducing the future availability of the resource.
> In org.?apache.?cloudstack.?network.?contrail.?management.?ManagementNetworkGuru.?configure(java.?lang.?String, java.?util.?Map): Leak of a system resource (CWE-404)
>
>
> Diffs
> -----
>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ManagementNetworkGuru.java e457023
>
> Diff: https://reviews.apache.org/r/15508/diff/
>
>
> Testing
> -------
>
> A test branch was created, the patch was applied against the branch and a full build was executed. Everything is working fine. The class changed is tested by MockLocalNfsSecondaryStorageResource.
>
>
> Thanks,
>
> Wilder Rodrigues
>
>