You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/11/17 02:14:09 UTC

[GitHub] [inlong] healchow commented on a diff in pull request #6562: [INLONG-6561][Manager] Fix the problem that the group cannot be deleted

healchow commented on code in PR #6562:
URL: https://github.com/apache/inlong/pull/6562#discussion_r1024686587


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/group/InlongGroupServiceImpl.java:
##########
@@ -453,6 +453,10 @@ public Boolean delete(String groupId, String operator) {
         InlongGroupEntity entity = groupMapper.selectByGroupId(groupId);
         Preconditions.checkNotNull(entity, ErrorCodeEnum.GROUP_NOT_FOUND.getMessage());
 

Review Comment:
   Suggest adding a comment: 
   ```
   before deleting an inlong group, delete all inlong streams, sources, sinks, and other info under it
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org