You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by krichter722 <gi...@git.apache.org> on 2018/05/21 21:46:14 UTC
[GitHub] commons-fileupload pull request #17: Move static analysis plugins from repor...
GitHub user krichter722 opened a pull request:
https://github.com/apache/commons-fileupload/pull/17
Move static analysis plugins from reporting to build
Moving the static code analysis plugins maven-checkstyle-plugin and
maven-pmd-plugin from the reporting to the build section and executing
them in the validate phase has the advantage to actively prevent code
style issues to ever be committed rather then passively react to them
after the report section has been run (not part of the current CI
script and build instructions anyway).
Some notes:
* PMD's `RedundantThrows` is no longer available. I can research the stackoverflow.com post again if you absolutely need a reference.
* Renaming tests ending in `TestCase` to `Test` and making the prefix `Mock` a suffix has been done for convenience.
* Some Javadoc comments in the form of "The [field name]" are poor. Leave a line comment is you have suggestions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/krichter722/commons-fileupload checkstyle
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/commons-fileupload/pull/17.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17
----
commit b33c20cab9e96ad89168569de08916a0b1539f38
Author: Karl-Philipp Richter <kr...@...>
Date: 2018-05-21T17:06:33Z
Move static analysis plugins from reporting to build
Moving the static code analysis plugins maven-checkstyle-plugin and
maven-pmd-plugin from the reporting to the build section and executing
them in the validate phase has the advantage to actively prevent code
style issues to ever be committed rather then passively react to them
after the report section has been run (not part of the current CI
script and build instructions anyway).
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
[GitHub] commons-fileupload issue #17: Move static analysis plugins from reporting to...
Posted by coveralls <gi...@git.apache.org>.
Github user coveralls commented on the issue:
https://github.com/apache/commons-fileupload/pull/17
[](https://coveralls.io/builds/17094811)
Coverage decreased (-0.1%) to 77.046% when pulling **b33c20cab9e96ad89168569de08916a0b1539f38 on krichter722:checkstyle** into **b1498c9877d751f8bc4635a6f252ebdfcba28518 on apache:master**.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org