You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@mesos.apache.org by "David Morrison (JIRA)" <ji...@apache.org> on 2018/01/30 17:37:00 UTC
[jira] [Commented] (MESOS-6827) Fix the order in which "self.hpp"
is included in "self.cpp".
[ https://issues.apache.org/jira/browse/MESOS-6827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16345492#comment-16345492 ]
David Morrison commented on MESOS-6827:
---------------------------------------
There are 462 files in {{/src}} violating the styleguide. I have a script that can correct these, I can submit a PR if people think this is worthwhile?
> Fix the order in which "self.hpp" is included in "self.cpp".
> ------------------------------------------------------------
>
> Key: MESOS-6827
> URL: https://issues.apache.org/jira/browse/MESOS-6827
> Project: Mesos
> Issue Type: Improvement
> Reporter: Alexander Rukletsov
> Priority: Minor
> Labels: newbie, tech-debt
>
> According to our [styleguide|https://github.com/apache/mesos/blob/master/docs/c%2B%2B-style-guide.md#order-of-includes], each {{.cpp}} file should include the related {{.hpp}} first to ensure that a header file always includes all symbols it requires. However, our codebase does not follow this rule strictly.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)