[GitHub] [incubator-nuttx] anchao commented on pull request #4080: net/socket: add SO_SNDBUF support

[GitBox <gi...@apache.org>]

anchao commented on pull request #4080:
URL: https://github.com/apache/incubator-nuttx/pull/4080#issuecomment-875244494


   > i looked at the tcp part.
   > 
   > * tcp_wrbuffer_tryalloc is not the only place we allocate IOBs. we allocate them in TCP_WBTRYCOPYIN too. i suspect it might be simpler to perform the check in psock_tcp_send.
   > * i guess you need to update poll.
   
   @yamt san,
   Think for a while, psock_tcp_send not suitable to check the buffer size, because it's hard to find a suitable place to notify that there are available buffers, TCP_WBTRYCOPYIN is a potential risk, but every time of tcp send() will only do the iobcopyin once, the next send() will be check further by tcp_wrbuffer_tryalloc(), I don't think it's a serious scene


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org