You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2011/03/24 16:59:05 UTC
[jira] [Created] (LUCENE-2990) Improve
ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or
one-element lists/arrays
Improve ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or one-element lists/arrays
------------------------------------------------------------------------------------------------------
Key: LUCENE-2990
URL: https://issues.apache.org/jira/browse/LUCENE-2990
Project: Lucene - Java
Issue Type: Improvement
Reporter: Uwe Schindler
Assignee: Uwe Schindler
Fix For: 3.2, 4.0
It might be a good idea to make CollectionUtil or ArrayUtil return early if the passed-in list or array's length <= 1 because sorting is unneeded then. This improves maybe automaton or other places, as for empty or one-element lists no SorterTermplate is created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (LUCENE-2990) Improve
ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or
one-element lists/arrays
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler resolved LUCENE-2990.
-----------------------------------
Resolution: Fixed
Lucene Fields: [New, Patch Available] (was: [New])
Renamed local variable from "l" to "size".
Committed trunk revision: 1085689
Committed 3.x revision: 1085691
> Improve ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or one-element lists/arrays
> ------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2990
> URL: https://issues.apache.org/jira/browse/LUCENE-2990
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-2990.patch, LUCENE-2990.patch, LUCENE-2990.patch
>
>
> It might be a good idea to make CollectionUtil or ArrayUtil return early if the passed-in list or array's length <= 1 because sorting is unneeded then. This improves maybe automaton or other places, as for empty or one-element lists no SorterTermplate is created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-2990) Improve
ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or
one-element lists/arrays
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2990:
----------------------------------
Attachment: LUCENE-2990.patch
Simplier patch (no duplicate checks, missed to see delegation).
> Improve ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or one-element lists/arrays
> ------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2990
> URL: https://issues.apache.org/jira/browse/LUCENE-2990
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-2990.patch, LUCENE-2990.patch
>
>
> It might be a good idea to make CollectionUtil or ArrayUtil return early if the passed-in list or array's length <= 1 because sorting is unneeded then. This improves maybe automaton or other places, as for empty or one-element lists no SorterTermplate is created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-2990) Improve
ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or
one-element lists/arrays
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2990:
----------------------------------
Attachment: LUCENE-2990.patch
> Improve ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or one-element lists/arrays
> ------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2990
> URL: https://issues.apache.org/jira/browse/LUCENE-2990
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-2990.patch
>
>
> It might be a good idea to make CollectionUtil or ArrayUtil return early if the passed-in list or array's length <= 1 because sorting is unneeded then. This improves maybe automaton or other places, as for empty or one-element lists no SorterTermplate is created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-2990) Improve
ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or
one-element lists/arrays
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2990:
----------------------------------
Attachment: LUCENE-2990.patch
Add corresponding tests
> Improve ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or one-element lists/arrays
> ------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2990
> URL: https://issues.apache.org/jira/browse/LUCENE-2990
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-2990.patch, LUCENE-2990.patch, LUCENE-2990.patch
>
>
> It might be a good idea to make CollectionUtil or ArrayUtil return early if the passed-in list or array's length <= 1 because sorting is unneeded then. This improves maybe automaton or other places, as for empty or one-element lists no SorterTermplate is created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-2990) Improve
ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or
one-element lists/arrays
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010818#comment-13010818 ]
Uwe Schindler commented on LUCENE-2990:
---------------------------------------
Will do. Courier New is an ugly font :-)
> Improve ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or one-element lists/arrays
> ------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2990
> URL: https://issues.apache.org/jira/browse/LUCENE-2990
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-2990.patch, LUCENE-2990.patch, LUCENE-2990.patch
>
>
> It might be a good idea to make CollectionUtil or ArrayUtil return early if the passed-in list or array's length <= 1 because sorting is unneeded then. This improves maybe automaton or other places, as for empty or one-element lists no SorterTermplate is created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (LUCENE-2990) Improve
ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or
one-element lists/arrays
Posted by "Uwe Schindler (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Uwe Schindler updated LUCENE-2990:
----------------------------------
Priority: Trivial (was: Major)
> Improve ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or one-element lists/arrays
> ------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2990
> URL: https://issues.apache.org/jira/browse/LUCENE-2990
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 3.2, 4.0
>
>
> It might be a good idea to make CollectionUtil or ArrayUtil return early if the passed-in list or array's length <= 1 because sorting is unneeded then. This improves maybe automaton or other places, as for empty or one-element lists no SorterTermplate is created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Commented] (LUCENE-2990) Improve
ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or
one-element lists/arrays
Posted by "Simon Willnauer (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010816#comment-13010816 ]
Simon Willnauer commented on LUCENE-2990:
-----------------------------------------
Uwe patch looks good.
I wonder if we could change the variable name from l to length or maybe size.
I had to look twice here
{code}
if (l <= 1) return;
{code}
to realize that you don't compare one <= one :)
> Improve ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or one-element lists/arrays
> ------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2990
> URL: https://issues.apache.org/jira/browse/LUCENE-2990
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-2990.patch, LUCENE-2990.patch, LUCENE-2990.patch
>
>
> It might be a good idea to make CollectionUtil or ArrayUtil return early if the passed-in list or array's length <= 1 because sorting is unneeded then. This improves maybe automaton or other places, as for empty or one-element lists no SorterTermplate is created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org