You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/11/18 20:01:38 UTC
Review Request 28181: AlertGroup REST Endpoint Should Return Alert
Definition Source Type
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28181/
-----------------------------------------------------------
Review request for Ambari, Oleg Nechiporenko and Srimanth Gunturi.
Bugs: AMBARI-8375
https://issues.apache.org/jira/browse/AMBARI-8375
Repository: ambari
Description
-------
Information about alert definitions should contain it's {{type}}.
{code:title="source_type" : "PORT" or "WEB" or "SCRIPT" or "METRIC"|borderStyle=solid}
http://localhost:8080/api/v1/clusters/c1/alert_groups?fields=*
"AlertGroup" : {
"cluster_name" : "c1",
"default" : true,
"definitions" : [
{
"name" : "ganglia_monitor_mapreduce_history_server",
"label" : "Ganglia History Server Process Monitor",
"enabled" : true,
"service_name" : "GANGLIA",
"component_name" : "GANGLIA_SERVER",
"id" : 1,
"source_type" : "PORT"
},
...
{code}
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AlertDefinitionResponse.java 908fed8
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java 422c6f2
Diff: https://reviews.apache.org/r/28181/diff/
Testing
-------
mvn clean test
Thanks,
Jonathan Hurley
Re: Review Request 28181: AlertGroup REST Endpoint Should Return Alert
Definition Source Type
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28181/#review62004
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Nov. 18, 2014, 7:01 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28181/
> -----------------------------------------------------------
>
> (Updated Nov. 18, 2014, 7:01 p.m.)
>
>
> Review request for Ambari, Oleg Nechiporenko and Srimanth Gunturi.
>
>
> Bugs: AMBARI-8375
> https://issues.apache.org/jira/browse/AMBARI-8375
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Information about alert definitions should contain it's {{type}}.
>
> {code:title="source_type" : "PORT" or "WEB" or "SCRIPT" or "METRIC"|borderStyle=solid}
> http://localhost:8080/api/v1/clusters/c1/alert_groups?fields=*
> "AlertGroup" : {
> "cluster_name" : "c1",
> "default" : true,
> "definitions" : [
> {
> "name" : "ganglia_monitor_mapreduce_history_server",
> "label" : "Ganglia History Server Process Monitor",
> "enabled" : true,
> "service_name" : "GANGLIA",
> "component_name" : "GANGLIA_SERVER",
> "id" : 1,
> "source_type" : "PORT"
> },
> ...
> {code}
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/AlertDefinitionResponse.java 908fed8
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/AlertGroupResourceProviderTest.java 422c6f2
>
> Diff: https://reviews.apache.org/r/28181/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Jonathan Hurley
>
>