[jira] [Commented] (FLINK-3736) Move toRexNode and toAggCall logic into Expressions

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-3736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15235618#comment-15235618 ] 

ASF GitHub Bot commented on FLINK-3736:
---------------------------------------

GitHub user yjshen opened a pull request:

    https://github.com/apache/flink/pull/1870

    [FLINK-3736][TableAPI]Move toRexNode & toAggCall logic into each expression's implementation

    Since we have a one-to-one mapping from Flink `Expression` to Calcite `RexNode`, I think it's a good practice to make `toRexNode` a behaviour of each Expression. 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yjshen/flink toRexNode

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1870.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1870
    
----
commit 32085a3f559a9d5510a85de01c63a23ce5497535
Author: Yijie Shen <he...@gmail.com>
Date:   2016-04-11T17:33:15Z

    move toRexNode logic into each expression's implementation

----


> Move toRexNode and toAggCall logic into Expressions
> ---------------------------------------------------
>
>                 Key: FLINK-3736
>                 URL: https://issues.apache.org/jira/browse/FLINK-3736
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API
>            Reporter: Yijie Shen
>            Priority: Minor
>
> Since we have a one-to-one mapping from Flink {{Expression}} to Calcite {{RexNode}}, and we will implement more and more expressions to make flink-table a full-fledged module, I think it's worthwhile to let each {{Expression}} take care of its own behaviour on conversion to {{RexNode}}.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)