You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Nigel Daley (JIRA)" <ji...@apache.org> on 2007/05/22 21:07:16 UTC
[jira] Created: (HADOOP-1417) Exclude some Findbugs detectors
Exclude some Findbugs detectors
-------------------------------
Key: HADOOP-1417
URL: https://issues.apache.org/jira/browse/HADOOP-1417
Project: Hadoop
Issue Type: Improvement
Components: build
Affects Versions: 0.14.0
Reporter: Nigel Daley
Priority: Minor
Fix For: 0.14.0
Exclude these detectors from Findbugs:
- May expose internal representation by returning reference to mutable object
- May expose internal representation by incorporating reference to mutable object
- Comparator doesn't implement Serializable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1417) Exclude some Findbugs detectors
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12503924 ]
Owen O'Malley commented on HADOOP-1417:
---------------------------------------
I like Nigel's list and Raghu's dead stores in the jsp. Sleeping with a lock held is never good and should be explained on a case by case basis.
> Exclude some Findbugs detectors
> -------------------------------
>
> Key: HADOOP-1417
> URL: https://issues.apache.org/jira/browse/HADOOP-1417
> Project: Hadoop
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.14.0
> Reporter: Nigel Daley
> Priority: Minor
> Fix For: 0.14.0
>
>
> Exclude these detectors from Findbugs:
> - May expose internal representation by returning reference to mutable object
> - May expose internal representation by incorporating reference to mutable object
> - Comparator doesn't implement Serializable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1417) Exclude some Findbugs detectors
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Doug Cutting updated HADOOP-1417:
---------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thanks, Nigel!
> Exclude some Findbugs detectors
> -------------------------------
>
> Key: HADOOP-1417
> URL: https://issues.apache.org/jira/browse/HADOOP-1417
> Project: Hadoop
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.14.0
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.14.0
>
> Attachments: 1417.patch
>
>
> Exclude these detectors from Findbugs:
> - May expose internal representation by returning reference to mutable object
> - May expose internal representation by incorporating reference to mutable object
> - Comparator doesn't implement Serializable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1417) Exclude some Findbugs detectors
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12504040 ]
Hadoop QA commented on HADOOP-1417:
-----------------------------------
+1
http://issues.apache.org/jira/secure/attachment/12359543/1417.patch applied and successfully tested against trunk revision r546320.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/274/testReport/
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/274/console
> Exclude some Findbugs detectors
> -------------------------------
>
> Key: HADOOP-1417
> URL: https://issues.apache.org/jira/browse/HADOOP-1417
> Project: Hadoop
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.14.0
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.14.0
>
> Attachments: 1417.patch
>
>
> Exclude these detectors from Findbugs:
> - May expose internal representation by returning reference to mutable object
> - May expose internal representation by incorporating reference to mutable object
> - Comparator doesn't implement Serializable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1417) Exclude some Findbugs detectors
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-1417:
--------------------------------
Attachment: 1417.patch
Here's a patch that excludes these items. On current trunk, the number of findbugs warnings is now 122 after this patch.
> Exclude some Findbugs detectors
> -------------------------------
>
> Key: HADOOP-1417
> URL: https://issues.apache.org/jira/browse/HADOOP-1417
> Project: Hadoop
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.14.0
> Reporter: Nigel Daley
> Priority: Minor
> Fix For: 0.14.0
>
> Attachments: 1417.patch
>
>
> Exclude these detectors from Findbugs:
> - May expose internal representation by returning reference to mutable object
> - May expose internal representation by incorporating reference to mutable object
> - Comparator doesn't implement Serializable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1417) Exclude some Findbugs detectors
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12505461 ]
Hadoop QA commented on HADOOP-1417:
-----------------------------------
Integrated in Hadoop-Nightly #123 (See [http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Nightly/123/])
> Exclude some Findbugs detectors
> -------------------------------
>
> Key: HADOOP-1417
> URL: https://issues.apache.org/jira/browse/HADOOP-1417
> Project: Hadoop
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.14.0
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.14.0
>
> Attachments: 1417.patch
>
>
> Exclude these detectors from Findbugs:
> - May expose internal representation by returning reference to mutable object
> - May expose internal representation by incorporating reference to mutable object
> - Comparator doesn't implement Serializable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-1417) Exclude some Findbugs detectors
Posted by "Nigel Daley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Nigel Daley updated HADOOP-1417:
--------------------------------
Assignee: Nigel Daley
Status: Patch Available (was: Open)
> Exclude some Findbugs detectors
> -------------------------------
>
> Key: HADOOP-1417
> URL: https://issues.apache.org/jira/browse/HADOOP-1417
> Project: Hadoop
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.14.0
> Reporter: Nigel Daley
> Assignee: Nigel Daley
> Priority: Minor
> Fix For: 0.14.0
>
> Attachments: 1417.patch
>
>
> Exclude these detectors from Findbugs:
> - May expose internal representation by returning reference to mutable object
> - May expose internal representation by incorporating reference to mutable object
> - Comparator doesn't implement Serializable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-1417) Exclude some Findbugs detectors
Posted by "Raghu Angadi (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-1417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12498060 ]
Raghu Angadi commented on HADOOP-1417:
--------------------------------------
Another candidate:
* Dead stores in {{*_jsp._jspService()}} method. These are the stores of JSP default variables that may not be read JSP code.
* (Arguable) : {{Thread.Sleep();}} inside synchronized : This should be a conscious decision by the developer. If it is not, it should be caught by the reviewers.
> Exclude some Findbugs detectors
> -------------------------------
>
> Key: HADOOP-1417
> URL: https://issues.apache.org/jira/browse/HADOOP-1417
> Project: Hadoop
> Issue Type: Improvement
> Components: build
> Affects Versions: 0.14.0
> Reporter: Nigel Daley
> Priority: Minor
> Fix For: 0.14.0
>
>
> Exclude these detectors from Findbugs:
> - May expose internal representation by returning reference to mutable object
> - May expose internal representation by incorporating reference to mutable object
> - Comparator doesn't implement Serializable
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.