You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Prasanna Santhanam <ts...@apache.org> on 2013/05/20 15:46:20 UTC
Review Request: [ACS41][PATCH] CLOUDSTACK-2554: XCP 1.6 fails to load
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11238/
-----------------------------------------------------------
Review request for cloudstack and Chip Childers.
Description
-------
CLOUDSTACK-2554: CloudStack fails to load XCP 1.6 hypervisors
Missing default constructor fails the agent manager reloading the XCP
resource on reboot of management server. This is fixed by using the
default constructor as do other Xen resources and include a new resource
ala XenServers for XCP1.6.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit 806aeb990d28179ff532e97dbf64f87cd3d5ca34)
Conflicts:
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
This addresses bug CLOUDSTACK-2554.
Diffs
-----
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java 04982a5
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 52641f6
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java PRE-CREATION
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java e4fc9ef
Diff: https://reviews.apache.org/r/11238/diff/
Testing
-------
This was tested against the build from master with the BVT across xen 6.0.2, kvm and xcp 1.6.
Thanks,
Prasanna Santhanam
Re: Review Request: [ACS41][PATCH] CLOUDSTACK-2554: XCP 1.6 fails to load
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11238/#review20778
-----------------------------------------------------------
Commit 85d54cd1c088997dd08f0328984bee1a55703636 in branch refs/heads/vmsync from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=85d54cd ]
CLOUDSTACK-2554: Incorrect compute of minmemory and cpu
23e54bb0 introduced multiple hypervisors support for cpu and memory
overcommit. Here the HypervisorGuru base which determines the min, max
range for the memory for all hypervisors computes the minCpu using the
MemoryOverCommit ratio and minMemory using the CpuOverCommit ratio.
Minor typo/logic issue but massive damage across all HV if enabled ;)
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On May 20, 2013, 1:46 p.m., Prasanna Santhanam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11238/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 1:46 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> CLOUDSTACK-2554: CloudStack fails to load XCP 1.6 hypervisors
>
> Missing default constructor fails the agent manager reloading the XCP
> resource on reboot of management server. This is fixed by using the
> default constructor as do other Xen resources and include a new resource
> ala XenServers for XCP1.6.
>
> Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> (cherry picked from commit 806aeb990d28179ff532e97dbf64f87cd3d5ca34)
>
> Conflicts:
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
>
> Signed-off-by: Prasanna Santhanam <ts...@apache.org>
>
>
> This addresses bug CLOUDSTACK-2554.
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java 04982a5
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 52641f6
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java PRE-CREATION
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java e4fc9ef
>
> Diff: https://reviews.apache.org/r/11238/diff/
>
>
> Testing
> -------
>
> This was tested against the build from master with the BVT across xen 6.0.2, kvm and xcp 1.6.
>
>
> Thanks,
>
> Prasanna Santhanam
>
>
Re: Review Request: [ACS41][PATCH] CLOUDSTACK-2554: XCP 1.6 fails to load
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11238/#review20782
-----------------------------------------------------------
Commit 8ea1601bd3a9ad04f6f0a6c03be540303d05fef8 in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8ea1601 ]
CLOUDSTACK-2554: CloudStack fails to load XCP 1.6 hypervisors
Missing default constructor fails the agent manager reloading the XCP
resource on reboot of management server. This is fixed by using the
default constructor as do other Xen resources and include a new resource
ala XenServers for XCP1.6.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
(cherry picked from commit 806aeb990d28179ff532e97dbf64f87cd3d5ca34)
Conflicts:
plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On May 20, 2013, 1:46 p.m., Prasanna Santhanam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11238/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 1:46 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> CLOUDSTACK-2554: CloudStack fails to load XCP 1.6 hypervisors
>
> Missing default constructor fails the agent manager reloading the XCP
> resource on reboot of management server. This is fixed by using the
> default constructor as do other Xen resources and include a new resource
> ala XenServers for XCP1.6.
>
> Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> (cherry picked from commit 806aeb990d28179ff532e97dbf64f87cd3d5ca34)
>
> Conflicts:
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
>
> Signed-off-by: Prasanna Santhanam <ts...@apache.org>
>
>
> This addresses bug CLOUDSTACK-2554.
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java 04982a5
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 52641f6
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java PRE-CREATION
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java e4fc9ef
>
> Diff: https://reviews.apache.org/r/11238/diff/
>
>
> Testing
> -------
>
> This was tested against the build from master with the BVT across xen 6.0.2, kvm and xcp 1.6.
>
>
> Thanks,
>
> Prasanna Santhanam
>
>
Re: Review Request: [ACS41][PATCH] CLOUDSTACK-2554: XCP 1.6 fails to load
Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11238/#review20783
-----------------------------------------------------------
Ship it!
Ship It!
- Chip Childers
On May 20, 2013, 1:46 p.m., Prasanna Santhanam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11238/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 1:46 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> CLOUDSTACK-2554: CloudStack fails to load XCP 1.6 hypervisors
>
> Missing default constructor fails the agent manager reloading the XCP
> resource on reboot of management server. This is fixed by using the
> default constructor as do other Xen resources and include a new resource
> ala XenServers for XCP1.6.
>
> Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> (cherry picked from commit 806aeb990d28179ff532e97dbf64f87cd3d5ca34)
>
> Conflicts:
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
>
> Signed-off-by: Prasanna Santhanam <ts...@apache.org>
>
>
> This addresses bug CLOUDSTACK-2554.
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java 04982a5
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 52641f6
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java PRE-CREATION
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java e4fc9ef
>
> Diff: https://reviews.apache.org/r/11238/diff/
>
>
> Testing
> -------
>
> This was tested against the build from master with the BVT across xen 6.0.2, kvm and xcp 1.6.
>
>
> Thanks,
>
> Prasanna Santhanam
>
>
Re: Review Request: [ACS41][PATCH] CLOUDSTACK-2554: XCP 1.6 fails to load
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11238/#review20780
-----------------------------------------------------------
Commit 806aeb990d28179ff532e97dbf64f87cd3d5ca34 in branch refs/heads/vmsync from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=806aeb9 ]
CLOUDSTACK-2554: CloudStack fails to load XCP 1.6 hypervisors
Missing default constructor fails the agent manager reloading the XCP
resource on reboot of management server. This is fixed by using the
default constructor as do other Xen resources and include a new resource
ala XenServers for XCP1.6.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On May 20, 2013, 1:46 p.m., Prasanna Santhanam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11238/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 1:46 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> CLOUDSTACK-2554: CloudStack fails to load XCP 1.6 hypervisors
>
> Missing default constructor fails the agent manager reloading the XCP
> resource on reboot of management server. This is fixed by using the
> default constructor as do other Xen resources and include a new resource
> ala XenServers for XCP1.6.
>
> Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> (cherry picked from commit 806aeb990d28179ff532e97dbf64f87cd3d5ca34)
>
> Conflicts:
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
>
> Signed-off-by: Prasanna Santhanam <ts...@apache.org>
>
>
> This addresses bug CLOUDSTACK-2554.
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java 04982a5
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 52641f6
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java PRE-CREATION
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java e4fc9ef
>
> Diff: https://reviews.apache.org/r/11238/diff/
>
>
> Testing
> -------
>
> This was tested against the build from master with the BVT across xen 6.0.2, kvm and xcp 1.6.
>
>
> Thanks,
>
> Prasanna Santhanam
>
>
Re: Review Request: [ACS41][PATCH] CLOUDSTACK-2554: XCP 1.6 fails to load
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11238/#review20779
-----------------------------------------------------------
Commit 7ea2c950f5c1c2446ae94087d7f78812cc94a658 in branch refs/heads/vmsync from Prasanna Santhanam <ts...@apache.org>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=7ea2c95 ]
CLOUDSTACK-2554: Ensuring that we honor hypervisor xen's memory constraints
When setting memory constraints on Xen guests we should honor:
static-min <= dynamic-min <= dynamic-max <= static-max
Our VmSpec while allows the guests to like between dynamic-min and
dynamic-max the memory set by the resource set the static min to be
equal to the dynamic max. This restricts the hypervisor from ensuring
optimized memory handling of guests.
see: http://wiki.xen.org/wiki/XCP_FAQ_Dynamic_Memory_Control#How_does_XCP_choose_targets_for_guests_in_dynamic_range_mode.3F
Another fix was related the restrict_dmc option. when enabled (true)
this option disallows scaling a vm. The logic was reverse handled
allowing scaling when restrict_dmc was on. This control flow is now
fixed.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On May 20, 2013, 1:46 p.m., Prasanna Santhanam wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11238/
> -----------------------------------------------------------
>
> (Updated May 20, 2013, 1:46 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> CLOUDSTACK-2554: CloudStack fails to load XCP 1.6 hypervisors
>
> Missing default constructor fails the agent manager reloading the XCP
> resource on reboot of management server. This is fixed by using the
> default constructor as do other Xen resources and include a new resource
> ala XenServers for XCP1.6.
>
> Signed-off-by: Prasanna Santhanam <ts...@apache.org>
> (cherry picked from commit 806aeb990d28179ff532e97dbf64f87cd3d5ca34)
>
> Conflicts:
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java
>
> Signed-off-by: Prasanna Santhanam <ts...@apache.org>
>
>
> This addresses bug CLOUDSTACK-2554.
>
>
> Diffs
> -----
>
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/discoverer/XcpServerDiscoverer.java 04982a5
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/CitrixHelper.java 52641f6
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServer16Resource.java PRE-CREATION
> plugins/hypervisors/xen/src/com/cloud/hypervisor/xen/resource/XcpServerResource.java e4fc9ef
>
> Diff: https://reviews.apache.org/r/11238/diff/
>
>
> Testing
> -------
>
> This was tested against the build from master with the BVT across xen 6.0.2, kvm and xcp 1.6.
>
>
> Thanks,
>
> Prasanna Santhanam
>
>