[GitHub] [cordova-plugin-splashscreen] breautek commented on issue #191: Can not disable splash screen for browser platform

[GitBox <gi...@apache.org>]

breautek commented on issue #191: Can not disable splash screen for browser platform
URL: https://github.com/apache/cordova-plugin-splashscreen/issues/191#issuecomment-550351499
 
 
   > I think the issue can be closed.
   
   I think this should be left open. One would think having `<preference name="ShowSplashScreen" value="false" />` will be sufficient to not show the splashscreen. Requiring to also have `<preference name="AutoHideSplashScreen" value="true" />` is confusing, doesn't make any real sense and probably a bug.
   
   While the workaround works, I think the condition should be changed to be smarter so it doesn't assume that it should call `SplashScreen.show();` when `AutoHideSplashScreen` is false. The condition should also consider looking at the `ShowSplashScreen` preference.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org