You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by Gentrio <gi...@git.apache.org> on 2018/02/05 09:47:13 UTC
[GitHub] incubator-weex pull request #1014: + [android] close #123, websocket operate...
GitHub user Gentrio opened a pull request:
https://github.com/apache/incubator-weex/pull/1014
+ [android] close #123, websocket operate on main thread
DefaultWebSocketAdapter will throw an exception when run on android 7.0
[https://developer.android.com/about/versions/nougat/android-7.0-changes.html](url)
> Due to a bug in previous versions of Android, the system did not flag writing to a TCP socket on the main thread as a strict-mode violation. Android 7.0 fixes this bug. Apps that exhibit this behavior now throw an android.os.NetworkOnMainThreadException. Generally, performing network operations on the main thread is a bad idea because these operations usually have a high tail latency that causes ANRs and jank.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Gentrio/incubator-weex android-bugfix-websocket
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1014.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1014
----
commit 431716bfd518baa405d8ed3ec4d8b3e948560b4c
Author: libai <li...@...>
Date: 2018-02-05T09:38:23Z
+ [android] close #123, websocket operate on main thread
----
---
[GitHub] incubator-weex issue #1014: * [android] close #123, websocket operate on mai...
Posted by misakuo <gi...@git.apache.org>.
Github user misakuo commented on the issue:
https://github.com/apache/incubator-weex/pull/1014
Duplicate with #1015
---
[GitHub] incubator-weex pull request #1014: * [android] close #123, websocket operate...
Posted by Gentrio <gi...@git.apache.org>.
Github user Gentrio closed the pull request at:
https://github.com/apache/incubator-weex/pull/1014
---
[GitHub] incubator-weex issue #1014: + [android] close #123, websocket operate on mai...
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1014
<!--
0 failure:
1 warning: No Changelog chan...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---