You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "rafafrdz (via GitHub)" <gi...@apache.org> on 2026/03/28 18:25:08 UTC
[PR] [SPARK-53316] Add Null literal type and improve from_str_name [spark-connect-rust]
rafafrdz opened a new pull request, #15:
URL: https://github.com/apache/spark-connect-rust/pull/15
## Summary
- Add `lit_null()` function to create a null literal column (`LiteralType::Null` with `DataType::Null`)
- Expand `DataType::from_str_name()` from 3 match arms to 16, covering all simple types (null, binary, boolean, byte, short, integer, long, float, double, decimal, string, date, timestamp, timestamp_ntz, calendar_interval)
- Improve the `unimplemented!` message to include the unsupported type name
## Test plan
- [x] Unit test for `lit_null()` verifying it produces a `LiteralType::Null`
- [x] Unit test for `from_str_name()` covering all 16 type variants
- [x] `cargo build` passes
- [x] `cargo fmt -- --check` passes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53316] Add Null literal type and improve from_str_name [spark-connect-rust]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #15:
URL: https://github.com/apache/spark-connect-rust/pull/15#issuecomment-5403906100
Superseded by #50, which delivers the consolidated Rust core Spark Connect client (now merged to `master`) and incorporates this work. Closing to keep the queue focused on the drop-in Python wrapper (#51). Thanks for the contribution — please reopen if anything here isn't covered by #50.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-53316] Add Null literal type and improve from_str_name [spark-connect-rust]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #15: [SPARK-53316] Add Null literal type and improve from_str_name
URL: https://github.com/apache/spark-connect-rust/pull/15
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org