You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "justinpark (via GitHub)" <gi...@apache.org> on 2023/04/10 17:39:39 UTC
[GitHub] [superset] justinpark opened a new pull request, #23638: fix: warning of nth-child
justinpark opened a new pull request, #23638:
URL: https://github.com/apache/superset/pull/23638
### SUMMARY
This commit replaces the `nth-child` css selector by `nth-of-type-` selector to fix the SSR warning.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
<img width="661" alt="Screenshot 2023-04-10 at 10 36 38 AM" src="https://user-images.githubusercontent.com/1392866/230958740-cfa5d275-36d8-4eae-a6cc-f890759318cb.png">
Before:
<img width="647" alt="Screenshot_2023-04-10_at_10_28_48_AM" src="https://user-images.githubusercontent.com/1392866/230958921-5d16ca37-7e61-42c6-b483-29adf57bccb5.png">
### TESTING INSTRUCTIONS
Go to SqlLab and open the developer console
Check the warning message
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23638: fix: warning of nth-child
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23638:
URL: https://github.com/apache/superset/pull/23638#issuecomment-1507248165
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] justinpark commented on pull request #23638: fix: warning of nth-child
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark commented on PR #23638:
URL: https://github.com/apache/superset/pull/23638#issuecomment-1502101613
cc: @michael-s-molina @ktmud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #23638: fix: warning of nth-child
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #23638:
URL: https://github.com/apache/superset/pull/23638#issuecomment-1507250579
@rusackas Ephemeral environment spinning up at http://35.163.78.30:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: warning of nth-child [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark merged PR #23638:
URL: https://github.com/apache/superset/pull/23638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23638: fix: warning of nth-child
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23638:
URL: https://github.com/apache/superset/pull/23638#issuecomment-1502161077
## [Codecov](https://codecov.io/gh/apache/superset/pull/23638?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23638](https://codecov.io/gh/apache/superset/pull/23638?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5f6fec2) into [master](https://codecov.io/gh/apache/superset/commit/b613167636aae82170b24f697d79fcd70ef1ac56?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b613167) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 5f6fec2 differs from pull request most recent head ec9c623. Consider uploading reports for the commit ec9c623 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23638 +/- ##
=======================================
Coverage 67.71% 67.71%
=======================================
Files 1918 1918
Lines 74157 74157
Branches 8053 8053
=======================================
Hits 50219 50219
Misses 21885 21885
Partials 2053 2053
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.90% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...allel-coordinates/src/ReactParallelCoordinates.jsx](https://codecov.io/gh/apache/superset/pull/23638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcGx1Z2luLWNoYXJ0LXBhcmFsbGVsLWNvb3JkaW5hdGVzL3NyYy9SZWFjdFBhcmFsbGVsQ29vcmRpbmF0ZXMuanN4) | `0.00% <ø> (ø)` | |
| [...plugins/legacy-preset-chart-nvd3/src/ReactNVD3.jsx](https://codecov.io/gh/apache/superset/pull/23638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9sZWdhY3ktcHJlc2V0LWNoYXJ0LW52ZDMvc3JjL1JlYWN0TlZEMy5qc3g=) | `0.00% <ø> (ø)` | |
| [...qlLab/components/SaveDatasetActionButton/index.tsx](https://codecov.io/gh/apache/superset/pull/23638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1NhdmVEYXRhc2V0QWN0aW9uQnV0dG9uL2luZGV4LnRzeA==) | `83.33% <ø> (ø)` | |
| [...rset-frontend/src/components/ButtonGroup/index.tsx](https://codecov.io/gh/apache/superset/pull/23638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQnV0dG9uR3JvdXAvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...t-frontend/src/components/DropdownButton/index.tsx](https://codecov.io/gh/apache/superset/pull/23638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHJvcGRvd25CdXR0b24vaW5kZXgudHN4) | `85.00% <ø> (ø)` | |
| [...nd/src/components/DropdownSelectableIcon/index.tsx](https://codecov.io/gh/apache/superset/pull/23638?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRHJvcGRvd25TZWxlY3RhYmxlSWNvbi9pbmRleC50c3g=) | `94.44% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #23638: fix: warning of nth-child
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on PR #23638:
URL: https://github.com/apache/superset/pull/23638#issuecomment-1650362238
@justinpark is this still on the radar? I love the cleanup work :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: warning of nth-child [superset]
Posted by "justinpark (via GitHub)" <gi...@apache.org>.
justinpark closed pull request #23638: fix: warning of nth-child
URL: https://github.com/apache/superset/pull/23638
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org