[GitHub] [iceberg] rdblue commented on a change in pull request #3837: Spark: Fix `Table UUID does not match` problem when enable CachingCatalog

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3837:
URL: https://github.com/apache/iceberg/pull/3837#discussion_r778362589



##########
File path: core/src/main/java/org/apache/iceberg/CachingCatalog.java
##########
@@ -164,19 +164,20 @@ public Table loadTable(TableIdentifier ident) {
   @Override
   public boolean dropTable(TableIdentifier ident, boolean purge) {
     boolean dropped = catalog.dropTable(ident, purge);
-    invalidate(canonicalizeIdentifier(ident));
+    invalidate(ident);
     return dropped;
   }
 
   @Override
   public void renameTable(TableIdentifier from, TableIdentifier to) {
     catalog.renameTable(from, to);
-    invalidate(canonicalizeIdentifier(from));
+    invalidate(from);
   }
 
-  private void invalidate(TableIdentifier ident) {
-    tableCache.invalidate(ident);
-    tableCache.invalidateAll(metadataTableIdentifiers(ident));
+  public void invalidate(TableIdentifier ident) {

Review comment:
       Why is this now public?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org