Re: svn commit: r19992 - trunk/subversion/svnserve

[Garrett Rooney <ro...@electricjellyfish.net>]

On 6/13/06, Madan U Sreenivasan <ma...@collab.net> wrote:

> Do you think such a long comment is required here? The reason is anyways
> explained in the log...Also  I think this will confuse the reader, as to
> why such a long comment was deemed necessary.
>
> Not a big deal... just my two cents worth :)

The long comment is there because it's incredibly weird and
nonintuitive that we should have to destroy that pool in order for
things to work, and incredibly weird things should be documented in
the code, not just in a commit log.

Of course, Branko is working on a fix to make that pool destruction
entirely unnecessary, but if it was going to live on in the code the
comment would be appropriate ;-)

-garrett

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r19992 - trunk/subversion/svnserve

[Branko Čibej <br...@xbc.nu>]

Garrett Rooney wrote:
> On 6/13/06, Madan U Sreenivasan <ma...@collab.net> wrote:
>
>> Do you think such a long comment is required here? The reason is anyways
>> explained in the log...Also  I think this will confuse the reader, as to
>> why such a long comment was deemed necessary.
>>
>> Not a big deal... just my two cents worth :)
>
> The long comment is there because it's incredibly weird and
> nonintuitive that we should have to destroy that pool in order for
> things to work, and incredibly weird things should be documented in
> the code, not just in a commit log.
I absolutely agree about that comment being necessary.

> Of course, Branko is working on a fix to make that pool destruction
> entirely unnecessary, but if it was going to live on in the code the
> comment would be appropriate ;-)
Heh, I promise to rip out the comment as soon as the pool dsctruction
becomes unnecessary.

I'll dent a few walls hitting them with my head first, though ...

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org