You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "xzyJavaX (via GitHub)" <gi...@apache.org> on 2023/01/30 10:53:56 UTC
[GitHub] [skywalking-java] xzyJavaX opened a new pull request, #445: refactor pipeline in jedis-plugin
xzyJavaX opened a new pull request, #445:
URL: https://github.com/apache/skywalking-java/pull/445
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #[10311](https://github.com/apache/skywalking/issues/10311)
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] pg-yang commented on pull request #445: refactor pipeline in jedis-plugin
Posted by "pg-yang (via GitHub)" <gi...@apache.org>.
pg-yang commented on PR #445:
URL: https://github.com/apache/skywalking-java/pull/445#issuecomment-1408845050
`Pipeline` and `Transaction` have two main methods such as `exec/sync` or `discard`. We'd better enhance these methods as well, especially for `Transaction`.
BTW, don't you plan to refactor jedis 4.x plugin?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #445: refactor pipeline in jedis-plugin
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #445:
URL: https://github.com/apache/skywalking-java/pull/445
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] pg-yang commented on a diff in pull request #445: refactor pipeline in jedis-plugin
Posted by "pg-yang (via GitHub)" <gi...@apache.org>.
pg-yang commented on code in PR #445:
URL: https://github.com/apache/skywalking-java/pull/445#discussion_r1090715129
##########
test/plugin/scenarios/jedis-3.1.x-plus-scenario/config/expectedData.yaml:
##########
@@ -101,44 +101,8 @@ segmentItems:
skipAnalysis: false
tags:
- {key: cache.type, value: Redis}
- - {key: cache.cmd, value: hset}
- - {key: cache.key, value: a}
- - {key: cache.op, value: write}
- - operationName: Jedis/hget
- operationId: 0
- parentSpanId: 0
- spanId: 6
- spanLayer: Cache
- startTime: gt 0
- endTime: gt 0
- componentId: 30
- isError: false
- spanType: Exit
- peer: redis-server:6379
- skipAnalysis: false
- tags:
- - {key: cache.type, value: Redis}
- - {key: cache.cmd, value: hget}
- - {key: cache.key, value: a}
- - {key: cache.op, value: read}
- - operationName: Jedis/hdel
- operationId: 0
- parentSpanId: 0
- spanId: 7
- spanLayer: Cache
- startTime: gt 0
- endTime: gt 0
- componentId: 30
- isError: false
- spanType: Exit
- peer: redis-server:6379
- skipAnalysis: false
- tags:
- - {key: cache.type, value: Redis}
- - {key: cache.cmd, value: hdel}
- - {key: cache.key, value: a}
- - {key: cache.op, value: write}
- - operationName: Jedis/set
+ - {key: cache.cmd, value: BATCH_EXECUTE}
+ - operationName: Jedis/exec
Review Comment:
The spanId should be `6`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xzyJavaX commented on pull request #445: refactor pipeline in jedis-plugin
Posted by "xzyJavaX (via GitHub)" <gi...@apache.org>.
xzyJavaX commented on PR #445:
URL: https://github.com/apache/skywalking-java/pull/445#issuecomment-1413544045
@pg-yang @wu-sheng Please take a look.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] xzyJavaX commented on pull request #445: refactor pipeline in jedis-plugin
Posted by "xzyJavaX (via GitHub)" <gi...@apache.org>.
xzyJavaX commented on PR #445:
URL: https://github.com/apache/skywalking-java/pull/445#issuecomment-1409986536
Yes, I plan to refactor jedis 4.x plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] pg-yang commented on pull request #445: refactor pipeline in jedis-plugin
Posted by "pg-yang (via GitHub)" <gi...@apache.org>.
pg-yang commented on PR #445:
URL: https://github.com/apache/skywalking-java/pull/445#issuecomment-1413689371
To make the plugins more stable, I suggest adding test cases for `discard`, etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] lujiajing1126 commented on pull request #445: refactor pipeline in jedis-plugin
Posted by "lujiajing1126 (via GitHub)" <gi...@apache.org>.
lujiajing1126 commented on PR #445:
URL: https://github.com/apache/skywalking-java/pull/445#issuecomment-1409906220
> BTW, are you going to refactor jedis 4.x plugin?
I found that in the current jedis 4.x plugin, the interception point seems to be weird.
`Connection.sendCommand` only appends command to the `RedisOutputStream` which is a buffer(by default `8 KiB`). The real round-trip happens when `flush()` is called. So as I understand, we are now measuring the TCP connection time to the Redis server rather than the execution time of the real command. Can you pls make a confirmation?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #445: refactor pipeline in jedis-plugin
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #445:
URL: https://github.com/apache/skywalking-java/pull/445#issuecomment-1410091633
As https://github.com/apache/skywalking-java/pull/444 changes a lot from project level, let's hold this PR an while. That PR will be merged soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #445: refactor pipeline in jedis-plugin
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #445:
URL: https://github.com/apache/skywalking-java/pull/445#issuecomment-1410195886
Updated with latest main branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org