You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/18 09:28:31 UTC

[GitHub] [airflow] ashb commented on a diff in pull request #25788: Properly check the existence of missing indexes

ashb commented on code in PR #25788:
URL: https://github.com/apache/airflow/pull/25788#discussion_r948885926


##########
airflow/models/dagrun.py:
##########
@@ -656,7 +656,7 @@ def _filter_tis_and_exclude_removed(dag: "DAG", tis: List[TI]) -> Iterable[TI]:
 
         tis = list(_filter_tis_and_exclude_removed(self.get_dag(), tis))
         missing_indexes = self._revise_mapped_task_indexes(tis, session=session)
-        if missing_indexes:
+        if missing_indexes and any(len(v) for _, v in missing_indexes.items()):

Review Comment:
   ```suggestion
           if missing_indexes and any(len(v) for v in missing_indexes.values()):
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org