[jira] [Commented] (BATCHEE-65) remove unnecessary try/catch in CDIBatchArtifactFactory

["Romain Manni-Bucau (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BATCHEE-65?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555978#comment-14555978 ] 

Romain Manni-Bucau commented on BATCHEE-65:
-------------------------------------------

Patch looks good, however it would be great to go a bit further and just 'rework CDIBatchArtifactFactory'. idea is to use CDi.current().getbeanManager() if CDi 1.1 is available and completely skip the storage in a map in our bean manager provider class. Do you want to add it in the patch?

> remove unnecessary try/catch in CDIBatchArtifactFactory
> -------------------------------------------------------
>
>                 Key: BATCHEE-65
>                 URL: https://issues.apache.org/jira/browse/BATCHEE-65
>             Project: BatchEE
>          Issue Type: Improvement
>          Components: jbatch-core
>    Affects Versions: 0.3-incubating
>            Reporter: Reinhard Sandtner
>            Priority: Minor
>             Fix For: 0.3-incubating
>
>         Attachments: BATCHEE-65.patch
>
>
> resolving a CDI-Bean is in a try/catch block which catches an Exception and does nothing. this hides useful information if an Exception has been thrown.
> you get a NPE if ie the reader could not be resolved but not the real exception.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)