[GitHub] [pinot] timsants commented on a diff in pull request #9661: bugfix: Add missing BIG_DECIMAL support for GenericRow serde

[GitBox <gi...@apache.org>]

timsants commented on code in PR #9661:
URL: https://github.com/apache/pinot/pull/9661#discussion_r1006066438


##########
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/genericrow/GenericRowSerializer.java:
##########
@@ -42,8 +44,8 @@ public class GenericRowSerializer {
   private final String[] _fieldNames;
   private final boolean[] _isSingleValueFields;
   private final DataType[] _storedTypes;
-  // Cache the encoded string bytes
-  private final Object[] _stringBytes;
+  // Cache the encoded objects as bytes
+  private final Object[] _objectBytes;

Review Comment:
   Looks like it was declared Object[] to work for the string multi-value case where the cached object is `byte[][]`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org