You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/18 03:26:26 UTC
[GitHub] [shardingsphere] Qianyi951015 opened a new pull request, #22250: Update Oracle SQL XMLCAST function and Pseudocolumn COLUMN_VALUE parse
Qianyi951015 opened a new pull request, #22250:
URL: https://github.com/apache/shardingsphere/pull/22250
Fixes #22249.
Ref: https://docs.oracle.com/en/database/oracle/oracle-database/12.2/sqlrf/XMLCAST.html#GUID-06563B93-1247-4F0C-B6BE-42DB3B1DB069
<img width="463" alt="image" src="https://user-images.githubusercontent.com/57847965/202609836-a68ee58e-8893-4e9b-b1d9-5dd560d1293e.png">
Ref: https://docs.oracle.com/cd/B19306_01/server.102/b14200/pseudocolumns004.htm
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #22250: Update Oracle SQL XMLCAST function and Pseudocolumn COLUMN_VALUE parse
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #22250:
URL: https://github.com/apache/shardingsphere/pull/22250#issuecomment-1319522973
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/22250?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22250](https://codecov.io/gh/apache/shardingsphere/pull/22250?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (87afdc8) into [master](https://codecov.io/gh/apache/shardingsphere/commit/83cad1c89621509ad36fbb5fce7f251254b419ec?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (83cad1c) will **increase** coverage by `0.02%`.
> The diff coverage is `33.33%`.
```diff
@@ Coverage Diff @@
## master #22250 +/- ##
============================================
+ Coverage 60.88% 60.90% +0.02%
Complexity 2552 2552
============================================
Files 4165 4165
Lines 57621 57623 +2
Branches 9755 9756 +1
============================================
+ Hits 35081 35094 +13
+ Misses 19580 19567 -13
- Partials 2960 2962 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/22250?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...itor/statement/impl/OracleStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/22250/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3FsLXBhcnNlci9kaWFsZWN0L29yYWNsZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9vcmFjbGUvdmlzaXRvci9zdGF0ZW1lbnQvaW1wbC9PcmFjbGVTdGF0ZW1lbnRTUUxWaXNpdG9yLmphdmE=) | `76.95% <33.33%> (+4.09%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] RaigorJiang merged pull request #22250: Update Oracle SQL XMLCAST function and Pseudocolumn COLUMN_VALUE parse
Posted by GitBox <gi...@apache.org>.
RaigorJiang merged PR #22250:
URL: https://github.com/apache/shardingsphere/pull/22250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org