You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2020/02/03 07:53:37 UTC

[GitHub] [kylin] wangxiaojing123 opened a new pull request #1091: KYLIN-4345 Build Global Dict by MR/Hive, Parallel Part Build Step implementation

wangxiaojing123 opened a new pull request #1091: KYLIN-4345 Build Global Dict by MR/Hive, Parallel Part Build Step implementation
URL: https://github.com/apache/kylin/pull/1091
 
 
   issue link: https://issues.apache.org/jira/browse/KYLIN-4345

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] wangxiaojing123 closed pull request #1091: KYLIN-4345 Build Global Dict by MR/Hive, Parallel Part Build Step implementation

Posted by GitBox <gi...@apache.org>.

wangxiaojing123 closed pull request #1091: KYLIN-4345 Build Global Dict by MR/Hive, Parallel Part Build Step implementation
URL: https://github.com/apache/kylin/pull/1091
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] coveralls commented on issue #1091: KYLIN-4345 Build Global Dict by MR/Hive, Parallel Part Build Step implementation

Posted by GitBox <gi...@apache.org>.

coveralls commented on issue #1091: KYLIN-4345 Build Global Dict by MR/Hive, Parallel Part Build Step implementation
URL: https://github.com/apache/kylin/pull/1091#issuecomment-581293990
 
 
   ## Pull Request Test Coverage Report for [Build 5582](https://coveralls.io/builds/28490927)
   
   * **1** of **256**   **(0.39%)**  changed or added relevant lines in **9** files are covered.
   * **6** unchanged lines in **4** files lost coverage.
   * Overall coverage decreased (**-0.07%**) to **27.461%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/BatchCubingJobBuilder2.java](https://coveralls.io/builds/28490927/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2FBatchCubingJobBuilder2.java#L63) | 0 | 5 | 0.0%
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/JobBuilderSupport.java](https://coveralls.io/builds/28490927/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2FJobBuilderSupport.java#L206) | 0 | 13 | 0.0%
   | [source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java](https://coveralls.io/builds/28490927/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveInputBase.java#L101) | 0 | 15 | 0.0%
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/BuildGlobalHiveDicPartPartitioner.java](https://coveralls.io/builds/28490927/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FBuildGlobalHiveDicPartPartitioner.java#L31) | 0 | 18 | 0.0%
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/BuildGlobalHiveDicPartBuildReducer.java](https://coveralls.io/builds/28490927/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FBuildGlobalHiveDicPartBuildReducer.java#L34) | 0 | 27 | 0.0%
   | [core-common/src/main/java/org/apache/kylin/common/KylinConfigBase.java](https://coveralls.io/builds/28490927/source?filename=core-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcommon%2FKylinConfigBase.java#L587) | 1 | 35 | 2.86%
   | [source-hive/src/main/java/org/apache/kylin/source/hive/MRHiveDictUtil.java](https://coveralls.io/builds/28490927/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FMRHiveDictUtil.java#L63) | 0 | 36 | 0.0%
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/BuildGlobalHiveDictPartBuildMapper.java](https://coveralls.io/builds/28490927/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FBuildGlobalHiveDictPartBuildMapper.java#L33) | 0 | 43 | 0.0%
   | [engine-mr/src/main/java/org/apache/kylin/engine/mr/steps/BuildGlobalHiveDictPartBuildJob.java](https://coveralls.io/builds/28490927/source?filename=engine-mr%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fengine%2Fmr%2Fsteps%2FBuildGlobalHiveDictPartBuildJob.java#L44) | 0 | 64 | 0.0%
   <!-- | **Total:** | **1** | **256** | **0.39%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [core-cube/src/main/java/org/apache/kylin/cube/inmemcubing/MemDiskStore.java](https://coveralls.io/builds/28490927/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Finmemcubing%2FMemDiskStore.java#L553) | 1 | 78.12% |
   | [source-hive/src/main/java/org/apache/kylin/source/hive/HiveInputBase.java](https://coveralls.io/builds/28490927/source?filename=source-hive%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fsource%2Fhive%2FHiveInputBase.java#L138) | 1 | 7.95% |
   | [core-cube/src/main/java/org/apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://coveralls.io/builds/28490927/source?filename=core-cube%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fcube%2Fcuboid%2FTreeCuboidScheduler.java#L124) | 2 | 68.46% |
   | [core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DefaultScheduler.java](https://coveralls.io/builds/28490927/source?filename=core-job%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fkylin%2Fjob%2Fimpl%2Fthreadpool%2FDefaultScheduler.java#L194) | 2 | 80.23% |
   <!-- | **Total:** | **6** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/28490927/badge)](https://coveralls.io/builds/28490927) |
   | :-- | --: |
   | Change from base [Build 5579](https://coveralls.io/builds/28488839): |  -0.07% |
   | Covered Lines: | 24182 |
   | Relevant Lines: | 88059 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] wangxiaojing123 commented on issue #1091: KYLIN-4345 Build Global Dict by MR/Hive, Parallel Part Build Step implementation

Posted by GitBox <gi...@apache.org>.

wangxiaojing123 commented on issue #1091: KYLIN-4345 Build Global Dict by MR/Hive, Parallel Part Build Step implementation
URL: https://github.com/apache/kylin/pull/1091#issuecomment-582219413
 
 
   Merge pr: https://github.com/apache/kylin/pull/1097

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [kylin] codecov-io commented on issue #1091: KYLIN-4345 Build Global Dict by MR/Hive, Parallel Part Build Step implementation

Posted by GitBox <gi...@apache.org>.

codecov-io commented on issue #1091: KYLIN-4345 Build Global Dict by MR/Hive, Parallel Part Build Step implementation
URL: https://github.com/apache/kylin/pull/1091#issuecomment-581290865
 
 
   # [Codecov](https://codecov.io/gh/apache/kylin/pull/1091?src=pr&el=h1) Report
   > Merging [#1091](https://codecov.io/gh/apache/kylin/pull/1091?src=pr&el=desc) into [master](https://codecov.io/gh/apache/kylin/commit/33c9f7528e886b1df0ab739648f6ae30bc5c979b?src=pr&el=desc) will **decrease** coverage by `0.05%`.
   > The diff coverage is `0.39%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/kylin/pull/1091/graphs/tree.svg?width=650&token=JawVgbgsVo&height=150&src=pr)](https://codecov.io/gh/apache/kylin/pull/1091?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##             master   #1091      +/-   ##
   ===========================================
   - Coverage     25.05%     25%   -0.06%     
   + Complexity     6223    6221       -2     
   ===========================================
     Files          1440    1444       +4     
     Lines         87830   88059     +229     
     Branches      12275   12299      +24     
   ===========================================
   + Hits          22006   22016      +10     
   - Misses        63666   63880     +214     
   - Partials       2158    2163       +5
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/kylin/pull/1091?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../org/apache/kylin/engine/mr/JobBuilderSupport.java](https://codecov.io/gh/apache/kylin/pull/1091/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvSm9iQnVpbGRlclN1cHBvcnQuamF2YQ==) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...va/org/apache/kylin/source/hive/HiveInputBase.java](https://codecov.io/gh/apache/kylin/pull/1091/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL0hpdmVJbnB1dEJhc2UuamF2YQ==) | `7.11% <0%> (+0.42%)` | `4 <0> (ø)` | :arrow_down: |
   | [...apache/kylin/engine/mr/BatchCubingJobBuilder2.java](https://codecov.io/gh/apache/kylin/pull/1091/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvQmF0Y2hDdWJpbmdKb2JCdWlsZGVyMi5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...gine/mr/steps/BuildGlobalHiveDictPartBuildJob.java](https://codecov.io/gh/apache/kylin/pull/1091/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQnVpbGRHbG9iYWxIaXZlRGljdFBhcnRCdWlsZEpvYi5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...ne/mr/steps/BuildGlobalHiveDicPartPartitioner.java](https://codecov.io/gh/apache/kylin/pull/1091/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQnVpbGRHbG9iYWxIaXZlRGljUGFydFBhcnRpdGlvbmVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...e/mr/steps/BuildGlobalHiveDicPartBuildReducer.java](https://codecov.io/gh/apache/kylin/pull/1091/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQnVpbGRHbG9iYWxIaXZlRGljUGFydEJ1aWxkUmVkdWNlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...a/org/apache/kylin/source/hive/MRHiveDictUtil.java](https://codecov.io/gh/apache/kylin/pull/1091/diff?src=pr&el=tree#diff-c291cmNlLWhpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL3NvdXJjZS9oaXZlL01SSGl2ZURpY3RVdGlsLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...e/mr/steps/BuildGlobalHiveDictPartBuildMapper.java](https://codecov.io/gh/apache/kylin/pull/1091/diff?src=pr&el=tree#diff-ZW5naW5lLW1yL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9lbmdpbmUvbXIvc3RlcHMvQnVpbGRHbG9iYWxIaXZlRGljdFBhcnRCdWlsZE1hcHBlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | |
   | [.../java/org/apache/kylin/common/KylinConfigBase.java](https://codecov.io/gh/apache/kylin/pull/1091/diff?src=pr&el=tree#diff-Y29yZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2t5bGluL2NvbW1vbi9LeWxpbkNvbmZpZ0Jhc2UuamF2YQ==) | `11.92% <2.85%> (-0.42%)` | `44 <0> (ø)` | |
   | [.../apache/kylin/cube/cuboid/TreeCuboidScheduler.java](https://codecov.io/gh/apache/kylin/pull/1091/diff?src=pr&el=tree#diff-Y29yZS1jdWJlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reWxpbi9jdWJlL2N1Ym9pZC9UcmVlQ3Vib2lkU2NoZWR1bGVyLmphdmE=) | `63.84% <0%> (-2.31%)` | `0% <0%> (ø)` | |
   | ... and [11 more](https://codecov.io/gh/apache/kylin/pull/1091/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/kylin/pull/1091?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/kylin/pull/1091?src=pr&el=footer). Last update [33c9f75...58c2b70](https://codecov.io/gh/apache/kylin/pull/1091?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services