You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Apoorv Naik <na...@gmail.com> on 2018/05/01 00:55:41 UTC
Re: Review Request 66876: ATLAS:2631: Tag Propagation : Change in
behavior of tag propagation for DELETED entities
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66876/#review202175
-----------------------------------------------------------
repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java
Line 920 (original), 921 (patched)
<https://reviews.apache.org/r/66876/#comment283855>
Do we have any case where this relation needs to be SOFT deleted ? If not, then changes look good.
- Apoorv Naik
On April 30, 2018, 10:42 p.m., Sarath Subramanian wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66876/
> -----------------------------------------------------------
>
> (Updated April 30, 2018, 10:42 p.m.)
>
>
> Review request for atlas, Apoorv Naik, Ashutosh Mestry, and Madhan Neethiraj.
>
>
> Bugs: ATLAS-2631
> https://issues.apache.org/jira/browse/ATLAS-2631
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Currently, when tag is propagated from entity1 to entity2, and entity1 is DELETED , tag is removed from entity1 but tag is still propagated to entity2.
>
> But new behavior is , tag should be removed from entity1 and entity2.
>
>
> Diffs
> -----
>
> repository/src/main/java/org/apache/atlas/repository/store/graph/v1/DeleteHandlerV1.java abaf509b
>
>
> Diff: https://reviews.apache.org/r/66876/diff/1/
>
>
> Testing
> -------
>
> https://builds.apache.org/view/A/view/Atlas/job/PreCommit-ATLAS-Build-Test/319/console
>
>
> Thanks,
>
> Sarath Subramanian
>
>