You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hairong Kuang (JIRA)" <ji...@apache.org> on 2007/12/14 20:52:44 UTC
[jira] Created: (HADOOP-2431) Test HDFS File Permissions
Test HDFS File Permissions
--------------------------
Key: HADOOP-2431
URL: https://issues.apache.org/jira/browse/HADOOP-2431
Project: Hadoop
Issue Type: Test
Components: test
Affects Versions: 0.15.1
Reporter: Hairong Kuang
Assignee: Hairong Kuang
Fix For: 0.16.0
This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2431) Test HDFS File Permissions
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-2431:
----------------------------------
Attachment: (was: PermissionsTestPlan.pdf)
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, testDFSPermission.patch, testDFSPermission1.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2431) Test HDFS File Permissions
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560605#action_12560605 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-2431:
------------------------------------------------
+1
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, PermissionsTestPlan2.pdf, testDFSPermission.patch, testDFSPermission1.patch, testDFSPermission2.patch, testDFSPermission3.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-2431) Test HDFS File
Permissions
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12561927#action_12561927 ]
shv edited comment on HADOOP-2431 at 1/23/08 7:04 PM:
----------------------------------------------------------------------
The build failure is related to HADOOP-2691, not to the patch.
I just committed this. Thank you Hairong.
was (Author: shv):
I just committed this. Thank you Hairong.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, PermissionsTestPlan2.pdf, testDFSPermission.patch, testDFSPermission1.patch, testDFSPermission2.patch, testDFSPermission3.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2431) Test HDFS File Permissions
Posted by "Konstantin Shvachko (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Konstantin Shvachko updated HADOOP-2431:
----------------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
I just committed this. Thank you Hairong.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, PermissionsTestPlan2.pdf, testDFSPermission.patch, testDFSPermission1.patch, testDFSPermission2.patch, testDFSPermission3.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2431) Test HDFS File Permissions
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560772#action_12560772 ]
Hadoop QA commented on HADOOP-2431:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12373577/testDFSPermission3.patch
against trunk revision r613446.
@author +1. The patch does not contain any @author tags.
javadoc +1. The javadoc tool did not generate any warning messages.
javac +1. The applied patch does not generate any new compiler warnings.
findbugs +1. The patch does not introduce any new Findbugs warnings.
core tests -1. The patch failed core unit tests.
contrib tests +1. The patch passed contrib unit tests.
Test results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1658/testReport/
Findbugs warnings: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1658/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1658/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://lucene.zones.apache.org:8080/hudson/job/Hadoop-Patch/1658/console
This message is automatically generated.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, PermissionsTestPlan2.pdf, testDFSPermission.patch, testDFSPermission1.patch, testDFSPermission2.patch, testDFSPermission3.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2431) Test HDFS File Permissions
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558892#action_12558892 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-2431:
------------------------------------------------
In NameNode, AccessControlException is thrown directly. RPC wraps it as a RemoteException. So client gets a RemoteException (wrapping AccessControlException).
The situation is similar for other IOException like "Cannot open filename". Shell we unwrap "Cannot open filename"? If yes, then it is better to modify RPC.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, testDFSPermission.patch, testDFSPermission1.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2431) Test HDFS File Permissions
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-2431:
----------------------------------
Status: Patch Available (was: Open)
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, PermissionsTestPlan2.pdf, testDFSPermission.patch, testDFSPermission1.patch, testDFSPermission2.patch, testDFSPermission3.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2431) Test HDFS File Permissions
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558867#action_12558867 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-2431:
------------------------------------------------
The tests are very systemic. Below are some comments for testPermissionSetting() and testOwnership().
- Suggestion: add LOG.info("NUM_TEST_PERMISSIONS=" + NUM_TEST_PERMISSIONS) to show the value.
- DEFAULT_PERMISSION may not be a constant although it is final:
FsPermission.applyUMask(...) is called during file/dir creation.
If it is a constant, it is better to use FsPermission.createImmutable(short).
In this case, it happens working fine for 777.
- re-throw RuntimeException in static{...}
- testPermissionSetting: case 4,5 not in the same order as they in the pdf file.
- testOwnership(OpType op): <user1, group3> but GROUP1_NAME in the code
- NON_EXISTENT_PATH: It is better to check the existence of the path before using it.
- setOwner(...): add assertFalse(expectDeny) right before catch(...)
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, testDFSPermission.patch, testDFSPermission1.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2431) Test HDFS File Permissions
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-2431:
----------------------------------
Attachment: PermissionsTestPlan1.pdf
Attach an updated test plan
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, testDFSPermission.patch, testDFSPermission1.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2431) Test HDFS File Permissions
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-2431:
----------------------------------
Attachment: PermissionsTestPlan2.pdf
Updated test plan.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, PermissionsTestPlan2.pdf, testDFSPermission.patch, testDFSPermission1.patch, testDFSPermission2.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2431) Test HDFS File Permissions
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559146#action_12559146 ]
Doug Cutting commented on HADOOP-2431:
--------------------------------------
Perhaps if the exception named in the RemoteException is a class that's loaded on the client and is permitted by the method signature, then RPC should automatically try to construct an instance and throw it. But that's not what RPC does today. If you feel it should do this, please file a separate issue.
The FileSystem API promises that applications which attempt to violate permissions will be thrown an AccessControlException. Today, until RPC is changed, we must intercept RemoteException and explicitly throw an AccessControlException. The fact that a particular FileSystem is implemented using RPC should be invisible to clients.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, testDFSPermission.patch, testDFSPermission1.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2431) Test HDFS File Permissions
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559789#action_12559789 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-2431:
------------------------------------------------
One more comment to the patch: the UnixUserGroupInformation constructor does not need to throw IOException.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, testDFSPermission.patch, testDFSPermission1.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2431) Test HDFS File Permissions
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560586#action_12560586 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-2431:
------------------------------------------------
In checkNonExistentFile(), each operation needs a try-catch. Otherwise, one of them throws a " Cannot open file" exception, the other operations will be be tested.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, PermissionsTestPlan2.pdf, testDFSPermission.patch, testDFSPermission1.patch, testDFSPermission2.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2431) Test HDFS File Permissions
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559145#action_12559145 ]
Owen O'Malley commented on HADOOP-2431:
---------------------------------------
I'm with Doug on this one. I think that dfs client should unwrap specific exceptions that are thrown back to the client. RPC wraps exceptions with RemoteException because the client may not have the thrown exception, but that is clearly not the case here. Unwrapped exceptions are much easier for the client to handle...
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, testDFSPermission.patch, testDFSPermission1.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2431) Test HDFS File Permissions
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-2431:
----------------------------------
Attachment: testDFSPermission2.patch
> The FileSystem API promises that applications which attempt to violate permissions will be thrown an AccessControlException.
+1. I will do it in a separate jira.
The patch incorporated all Nicholas's comments. It also added a test for non-existent paths.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, testDFSPermission.patch, testDFSPermission1.patch, testDFSPermission2.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2431) Test HDFS File Permissions
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12558874#action_12558874 ]
Doug Cutting commented on HADOOP-2431:
--------------------------------------
This tests that permission check failures throw a RemoteException wrapping an AccessControlException. Shouldn't permission check failures throw an AccessControlException directly?
DistributedFileSystem or DFSClient should catch the RemoteException and, when it wraps an AccessControlException, throw one of those so that client code sees that, no? Should I file a separate issue for this?
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, testDFSPermission.patch, testDFSPermission1.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-2431) Test HDFS File Permissions
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12562035#action_12562035 ]
Hudson commented on HADOOP-2431:
--------------------------------
Integrated in Hadoop-trunk #378 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/378/])
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop Core
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, PermissionsTestPlan2.pdf, testDFSPermission.patch, testDFSPermission1.patch, testDFSPermission2.patch, testDFSPermission3.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-2431) Test HDFS File
Permissions
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12560586#action_12560586 ]
szetszwo edited comment on HADOOP-2431 at 1/18/08 3:01 PM:
-------------------------------------------------------------------------
In checkNonExistentFile(), each operation needs a try-catch. Otherwise, one of them throws a " Cannot open file" exception, the other operations will not be tested.
was (Author: szetszwo):
In checkNonExistentFile(), each operation needs a try-catch. Otherwise, one of them throws a " Cannot open file" exception, the other operations will be be tested.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, PermissionsTestPlan2.pdf, testDFSPermission.patch, testDFSPermission1.patch, testDFSPermission2.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2431) Test HDFS File Permissions
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-2431:
----------------------------------
Attachment: testDFSPermission1.patch
I found one permission checking semantics error. Because dfs list is equivalent to unix "ls -l", listing a directory needs both SEARCH and READ permissions on the directory. This patch fixed the problem. It also added javadoc to the unit tests.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: PermissionsTestPlan.pdf, testDFSPermission.patch, testDFSPermission1.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2431) Test HDFS File Permissions
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-2431:
----------------------------------
Attachment: HDFSPermissionSpecification6.pdf
Attach the permission checking specification.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan.pdf, testDFSPermission.patch, testDFSPermission1.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2431) Test HDFS File Permissions
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-2431:
----------------------------------
Attachment: testDFSPermission3.patch
Thanks Nicholas. Here is a new patch.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: HDFSPermissionSpecification6.pdf, PermissionsTestPlan1.pdf, PermissionsTestPlan2.pdf, testDFSPermission.patch, testDFSPermission1.patch, testDFSPermission2.patch, testDFSPermission3.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2431) Test HDFS File Permissions
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-2431:
----------------------------------
Attachment: testDFSPermission.patch
The patch executes the test plan. In addition it fixed a bug in FileSystem.isDirectory(), which did not throw AccessControlException when the permission to call getFileStatus is denied.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: PermissionsTestPlan.pdf, testDFSPermission.patch
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-2431) Test HDFS File Permissions
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-2431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-2431:
----------------------------------
Attachment: PermissionsTestPlan.pdf
Test plan is attached.
> Test HDFS File Permissions
> --------------------------
>
> Key: HADOOP-2431
> URL: https://issues.apache.org/jira/browse/HADOOP-2431
> Project: Hadoop
> Issue Type: Test
> Components: test
> Affects Versions: 0.15.1
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.16.0
>
> Attachments: PermissionsTestPlan.pdf
>
>
> This jira is intended to provide junit tests to HADOOP-1298.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.