[jira] Commented: (WICKET-431) Modal window can not be closed after session timeout

["Rastislav Vojtko (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12928207#action_12928207 ] 

Rastislav  Vojtko commented on WICKET-431:
------------------------------------------

Matej, setting:
Wicket.Window.unloadConfirmation = false; 

does not help because the false case is not handled in the modal.js. To be more specific, instead of:

if (Wicket.Window.unloadConfirmation == true) {
	// new beforeunload handler - ask user before reloading window
	window.onbeforeunload = function() {
		return "Reloading this page will cause the modal window to disappear.";
	}
}

as it is now, should be:

if (Wicket.Window.unloadConfirmation == true) {
	// new beforeunload handler - ask user before reloading window
	window.onbeforeunload = function() {
		return "Reloading this page will cause the modal window to disappear.";
	}
} else {
        window.onbeforeunload = function() {}
}

because only and if only the window.onbeforeunload function doesn't return anything at all, the browser confirmation dialog will not be shown.

> Modal window can not be closed after session timeout
> ----------------------------------------------------
>
>                 Key: WICKET-431
>                 URL: https://issues.apache.org/jira/browse/WICKET-431
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket-extensions
>    Affects Versions: 1.2.5, 1.3.0-beta1
>         Environment: tested on Linux FF / Windows FF
>            Reporter: Francis De Brabandere
>            Assignee: Matej Knopp
>            Priority: Minor
>             Fix For: 1.3.5
>
>
> After session timeout, clicking on the close button (X) generates a warning message:
> 'Are you sure you want to .... Reloading this page will cause the modal window to disappear....'
> --> Maybe something about session timeout might be more meaningful?
> If you click 'Cancel' you are stuck with an unclosable modal window, the previous message won't be shown again.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.