[jira] [Commented] (SPARK-4123) Show dependency changes in pull requests

["Josh Rosen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SPARK-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14590389#comment-14590389 ] 

Josh Rosen commented on SPARK-4123:
-----------------------------------

Hasn't this been re-enabled?  Did we ever end up fixing this?

> Show dependency changes in pull requests
> ----------------------------------------
>
>                 Key: SPARK-4123
>                 URL: https://issues.apache.org/jira/browse/SPARK-4123
>             Project: Spark
>          Issue Type: Improvement
>          Components: Project Infra
>            Reporter: Patrick Wendell
>            Assignee: Brennon York
>            Priority: Critical
>
> We should inspect the classpath of Spark's assembly jar for every pull request. This only takes a few seconds in Maven and it will help weed out dependency changes from the master branch. Ideally we'd post any dependency changes in the pull request message.
> {code}
> $ mvn -Phive -Phadoop-2.4 dependency:build-classpath -pl assembly  | grep -v INFO | tr : "\n" | awk -F/ '{print $NF}' | sort > my-classpath
> $ git checkout apache/master
> $ mvn -Phive -Phadoop-2.4 dependency:build-classpath -pl assembly  | grep -v INFO | tr : "\n" | awk -F/ '{print $NF}' | sort > master-classpath
> $ diff my-classpath master-classpath
> < chill-java-0.3.6.jar
> < chill_2.10-0.3.6.jar
> ---
> > chill-java-0.5.0.jar
> > chill_2.10-0.5.0.jar
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org